Skip to content

Commit

Permalink
fix: remove reference to react in extension-sdk (#1532)
Browse files Browse the repository at this point in the history
Co-authored-by: John Kaster <kaster@google.com>
Co-authored-by: Dr. Strangelove <drstrangelove@google.com>
  • Loading branch information
3 people authored Oct 28, 2024
1 parent 1a0a89b commit bae0fe3
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
1 change: 0 additions & 1 deletion packages/extension-sdk/src/connect/tile/tile_sdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
*/

import type { MouseEvent } from 'react';
import { NOT_DASHBOARD_MOUNT_NOT_SUPPORTED_ERROR } from '../../util/errors';
import { ExtensionRequestType } from '../types';
import type { ExtensionHostApiImpl } from '../extension_host_api';
Expand Down
1 change: 0 additions & 1 deletion packages/extension-sdk/src/connect/tile/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
*/

import type { MouseEvent } from 'react';
import type { IQuery } from '@looker/sdk';

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
*/
import React, { useCallback, useContext, useState } from 'react';
import type { MouseEvent } from 'react';
import {
Accordion2,
ButtonOutline,
Expand Down Expand Up @@ -58,17 +57,20 @@ export const EventTester: React.FC = () => {
}, [tileSDK]);

const toggleCrossFilterClick = useCallback(
(event: MouseEvent) => {
(event: React.MouseEvent<HTMLButtonElement>) => {
// TODO pivot and row data needs to be populated
tileSDK.toggleCrossFilter({ pivot: {} as any, row: {} as any }, event);
tileSDK.toggleCrossFilter(
{ pivot: {} as any, row: {} as any },
event as unknown as MouseEvent
);
},
[tileSDK]
);

const openDrillMenuClick = useCallback(
(event: MouseEvent) => {
(event: React.MouseEvent<HTMLButtonElement>) => {
// TODO links data needs to be populated
tileSDK.openDrillMenu({ links: [] }, event);
tileSDK.openDrillMenu({ links: [] }, event as unknown as MouseEvent);
},
[tileSDK]
);
Expand Down

0 comments on commit bae0fe3

Please sign in to comment.