Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@looker/extension-sdk requires react #1438

Closed
AndrewKoliaka opened this issue Mar 1, 2024 · 2 comments
Closed

@looker/extension-sdk requires react #1438

AndrewKoliaka opened this issue Mar 1, 2024 · 2 comments
Assignees
@jkaster
Labels
p3 Priority 3 typescript Typescript or Javascript SDK issues

Comments

@AndrewKoliaka
Copy link

We use Looker in Angular project. And when I try to upgrade @looker/extension-sdk from 23.6.0 to the latest version 24.2.0 it breaks with the error:

ERROR in node_modules/@looker/extension-sdk/lib/connect/tile/types.d.ts:1:33 - error TS2307: Cannot find module 'react' or its corresponding type declarations.

1 import type { MouseEvent } from 'react';
@github-actions github-actions bot added p3 Priority 3 need triage labels Mar 1, 2024
@drstrangelooker drstrangelooker added typescript Typescript or Javascript SDK issues and removed need triage labels Oct 28, 2024
@drstrangelooker
Copy link
Collaborator

@bryans99 Is this resolved by #1532?

@jkaster jkaster mentioned this issue Oct 28, 2024
Merged
@jkaster
Copy link
Contributor

jkaster commented Oct 29, 2024

This should be resolved by #1532

@jkaster jkaster closed this as completed Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkaster jkaster

Labels
p3 Priority 3 typescript Typescript or Javascript SDK issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jkaster @drstrangelooker @AndrewKoliaka