From d7334157c5791db40f6be4da465c6a9142eb6c77 Mon Sep 17 00:00:00 2001 From: Jeremy Chang Date: Wed, 21 Feb 2024 21:12:31 +0000 Subject: [PATCH 1/2] update script --- bin/sdk_gen | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/bin/sdk_gen b/bin/sdk_gen index 2b362deca..250d9fd25 100755 --- a/bin/sdk_gen +++ b/bin/sdk_gen @@ -193,10 +193,12 @@ const regen = async (release) => { return batch( [ 'yarn gen', - 'bin/smoke typescript python kotlin', - 'git add -u', - `git commit -m "feat: generate SDKs for Looker ${release}" -m "Release-As: ${release}.0"`, - `git push origin ${branch}`, + 'yarn fix', // Fixes eslint + 'pipenv run black api40/*.py', + './kotlin/gradlew -p kotlin spotlessApply', + // 'git add -u', + // `git commit -m "feat: generate SDKs for Looker ${release}" -m "Release-As: ${release}.0"`, + // `git push origin ${branch}`, /* create PR */ ], @@ -214,6 +216,7 @@ const regen = async (release) => { const args = process.argv.slice(2); if (args.length >= 1) { await regen(args[0]); + console.info('If generated SDKs fail CI, run "bin/smoke [language]" locally to verify and debug') } else { console.error('No release version was specified'); } From 4791ef19d1c233c5a67c6ac24e64be0714e6fc8a Mon Sep 17 00:00:00 2001 From: Jeremy Chang Date: Wed, 21 Feb 2024 21:24:27 +0000 Subject: [PATCH 2/2] update sdk gen script --- bin/sdk_gen | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/bin/sdk_gen b/bin/sdk_gen index 250d9fd25..21e6c294a 100755 --- a/bin/sdk_gen +++ b/bin/sdk_gen @@ -193,12 +193,12 @@ const regen = async (release) => { return batch( [ 'yarn gen', - 'yarn fix', // Fixes eslint - 'pipenv run black api40/*.py', - './kotlin/gradlew -p kotlin spotlessApply', - // 'git add -u', - // `git commit -m "feat: generate SDKs for Looker ${release}" -m "Release-As: ${release}.0"`, - // `git push origin ${branch}`, + 'yarn fix', // Lint fix typescript + 'pipenv run black python/looker_sdk/sdk/api40/*.py', // Lint fix python + './kotlin/gradlew -p kotlin spotlessApply', // Lint fix kotlin + 'git add -u', + `git commit -m "feat: generate SDKs for Looker ${release}" -m "Release-As: ${release}.0"`, + `git push origin ${branch}`, /* create PR */ ],