Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mb-edit-set_work_attributes no longer functions #93

Open
yindesu opened this issue Dec 20, 2023 · 2 comments
Open

mb-edit-set_work_attributes no longer functions #93

yindesu opened this issue Dec 20, 2023 · 2 comments

Comments

@yindesu
Copy link

yindesu commented Dec 20, 2023

The URL include filter on https://github.com/loujine/musicbrainz-scripts/blob/master/mb-edit-set_work_attributes.user.js is too restrictive, but even expanding it, the userscript no longer functions as it originally did - neither the per-work dropdown lists nor the edit panel are drawn on https://musicbrainz.org/artist/53b106e7-0cc6-42cc-ac95-ed8d30a3a98e/works?filter.type_id=22&filter.name=&filter.role_type=

@mihawk90
Copy link

mihawk90 commented Mar 9, 2024

Same on Olivier Derivière
What's odd is that it shows a select field on the first Work ("We are Family"), but nothing else:
image

The same is true for John Williams mentioned above:
image

@mihawk90
Copy link

mihawk90 commented Nov 2, 2024

Hm, ran across this again with Ilan Eshkeri.

Oddly in that case, the select field mentioned above does not show up:

image

It still does on the 2 examples above.

The difference here being that the first row already has a Type, so it seems it's breaking on the first row overall. I first thought it was the first row without a type.

There is one error in the Dev Tools:

02:54:13.984 userscript.html?name=MusicBrainz-edit%253A-Set-work-attributes-from-the-composer-Work-page.user.js&id=3a5d4ece-794e-4f17-87bd-4c804d93d953:878 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'textContent')
    at HTMLTableRowElement.<anonymous> (userscript.html?name=MusicBrainz-edit%253A-Set-work-attributes-from-the-composer-Work-page.user.js&id=3a5d4ece-794e-4f17-87bd-4c804d93d953:878:32)
    at Function.each (jquery.js:384:23)
    at EVdnBjI.m.fn.init.each (jquery.js:136:17)
    at Object.<anonymous> (userscript.html?name=MusicBrainz-edit%253A-Set-work-attributes-from-the-composer-Work-page.user.js&id=3a5d4ece-794e-4f17-87bd-4c804d93d953:871:7)
    at Pt (<anonymous>:10:89)
    at userscript.html?name=MusicBrainz-edit%253A-Set-work-attributes-from-the-composer-Work-page.user.js&id=3a5d4ece-794e-4f17-87bd-4c804d93d953:1:89
    at window.__f__m2zl37d4.od (userscript.html?name=MusicBrainz-edit%253A-Set-work-attributes-from-the-composer-Work-page.user.js&id=3a5d4ece-794e-4f17-87bd-4c804d93d953:1:368)
    at Pt (<anonymous>:10:89)
    at r.setMessageListener.r (<anonymous>:86:186)
    at <anonymous>:89:107
    at _ (<anonymous>:22:406)
(anonymous) @ userscript.html?name=MusicBrainz-edit%253A-Set-work-attributes-from-the-composer-Work-page.user.js&id=3a5d4ece-794e-4f17-87bd-4c804d93d953:878
each @ jquery.js:384
each @ jquery.js:136
(anonymous) @ userscript.html?name=MusicBrainz-edit%253A-Set-work-attributes-from-the-composer-Work-page.user.js&id=3a5d4ece-794e-4f17-87bd-4c804d93d953:871
Pt @ VM135:10
(anonymous) @ userscript.html?name=MusicBrainz-edit%253A-Set-work-attributes-from-the-composer-Work-page.user.js&id=3a5d4ece-794e-4f17-87bd-4c804d93d953:1
window.__f__m2zl37d4.od @ userscript.html?name=MusicBrainz-edit%253A-Set-work-attributes-from-the-composer-Work-page.user.js&id=3a5d4ece-794e-4f17-87bd-4c804d93d953:1
Pt @ VM135:10
r.setMessageListener.r @ VM135:86
(anonymous) @ VM135:89
_ @ VM135:22
Show 2 more frames
Show less

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants