Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Character history cleanup #139

Open
2 of 4 tasks
rquinio opened this issue Mar 8, 2016 · 4 comments
Open
2 of 4 tasks

Character history cleanup #139

rquinio opened this issue Mar 8, 2016 · 4 comments
Labels
Help Wanted! There is a need for input and help from others. History Everything in relation to history.

Comments

@rquinio
Copy link
Collaborator

rquinio commented Mar 8, 2016 •
edited by loup99
Loading

I think a cleanup of character history and dynasties will be needed at some point, as it's a bit messy:

  • vanilla characters are still in the files, generating errors in the validator and masking the real errors. Any character born after 800 A.D. should be removed.
  • some characters have a different culture than the name of the file (in particular WtWSMS_character_gift.txt and the like, but also georgian.txt, finnish.txt, dutch.txt, etc.)
  • some characters and dynasties are duplicated (Meroving, ...) causing confusion
  • there's no clear ID range assigned per file/culture, making it easy to have duplicate IDs ?
@rquinio rquinio added the History Everything in relation to history. label Mar 8, 2016
@loup99
Copy link
Owner

loup99 commented Mar 9, 2016

Is this OK to do? Finally! One of the things I've wanted to do ever since I looked at the code for the first time, but the rest of the team seemingly didn't want.

@rquinio
Copy link
Collaborator Author

rquinio commented Mar 9, 2016

What were the reasons for not doing it ?
Obviously it has to be done at the right time, i.e. if @EmperorEnlil has big modifications/additions on his side that he hasn't shared yet, it will become impossible to merge after the cleanup.

@loup99
Copy link
Owner

loup99 commented Mar 9, 2016

No idea, not sure if they even existed. But every time I mentioned it I didn't get any answer, so I didn't know what to do or if it was just something that was to be avoided because it might mess up the code too much. And also what you say, Enlil/Zusk/Erik W are always working with new characters, so it felt difficult to do as I wasn't the onedoing those characters.

loup99 added a commit that referenced this issue Oct 1, 2016
@loup99
Started moving characters #139
ddc309a
loup99 pushed a commit that referenced this issue Jul 17, 2017
@IhateTrains @loup99
Cleaning history - part I (#274) #139
adf8161 
- Started Character history cleanup #139
loup99 pushed a commit that referenced this issue Jul 24, 2017
@IhateTrains @loup99
New Historical Buildings, removing duplicates, fixing errors, cleanin…
2eb0a45 
…g history (#285)

- New Historical Buildings
- Removing duplicates
- Fixing errors
- Cleaning history #139
loup99 pushed a commit that referenced this issue Jul 31, 2017
@IhateTrains @loup99
Historical Buildings + history cleaning (#295)
3ee4317 
1. Historical Buildings:
- Church of the Holy Sepulchre
- Temple of Zeus
- Golden Gate of Kiev
- Calat Alhambra
- Multiprovince Roman Limes
- Multiprovince Roman Roads
- tweaking

2. updating positions for Constantinople
3. finished character history cleaning from "a" to "i" cultures #139
4. Adapted the anachronistic reference to Varangian Guards in the Chariot racing event from Legacy of Rome to be more fitting for the mod setting
loup99 pushed a commit that referenced this issue Aug 30, 2017
@IhateTrains @loup99
Character history cleaned to pechenegs (#311) #139
b6962de 
Character history cleaned to pechenegs (#311)
loup99 pushed a commit that referenced this issue Oct 1, 2017
@IhateTrains @loup99
Finished character history cleaning #139
12bd290 
- removed post-800 characters
- converted pre-800 catholic and orthodox characters to nicene
- partial reorganisation
loup99 pushed a commit that referenced this issue Oct 28, 2017
@IhateTrains @loup99
Character history file reorganization #139 (#337)
bdf12d4 
- character history reorganization by @Abian36 and @IhateTrains 
- decision icon for the future Divide Roman Empire decision
@IhateTrains IhateTrains mentioned this issue Oct 28, 2017
Merged
loup99 pushed a commit that referenced this issue Oct 29, 2017
@IhateTrains @loup99
Big pack of history fixes (#338)
aedaacc 
- history fixes
- character reorganization #139 
- code cleaning
loup99 added a commit that referenced this issue Feb 2, 2018
@loup99
Continued Cleaning #139
37a5b3b 
- Removed personal files, they shouldn't be used
- Moved characters to the files of their culture
- Removed amorican.txt
loup99 added a commit that referenced this issue Feb 4, 2018
@loup99
Character Reorganisation #139
ffa5ccd 
- Deleted dutch.txt and moved characters to their respective culture files instead
loup99 added a commit that referenced this issue Feb 4, 2018
@loup99
More Character Reorganisation #139
83e8a6e 
- The first of the WtWSMS_character_gift files bites the dust, more is to come.
loup99 added a commit that referenced this issue Feb 12, 2018
@loup99
Further Character Reorganisation #139
85e13a6 
- bohemian.txt has been split up into relevant files
loup99 added a commit that referenced this issue Feb 13, 2018
@loup99
Continued Character Reorganisation #139
fd51d92 
- hungarian.txt has been split up into relevant files
loup99 added a commit that referenced this issue Feb 18, 2018
@loup99
Character Reorganisation #139
87c5f48 
- Moved characters to the correct files
- Removed Changelog.txt entry added on the wrong update
loup99 added a commit that referenced this issue Feb 18, 2018
@loup99
Further Character Reorganisation #139
bdc2e46 
- Moved more characters to the correct files
loup99 added a commit that referenced this issue Apr 3, 2018
@loup99
More Character Reorganisation #139
e0e32e8 
- Moved more characters to the correct files
loup99 added a commit that referenced this issue Jun 22, 2018
@loup99
Character Reorganisation #139
9c8e1d9 
- Removed sephardi.txt and moved characters to respective files
@loup99
Copy link
Owner

loup99 commented Apr 13, 2020

While the characters have been cleared up, the dynasties are still very confusing.

@loup99 loup99 added the Help Wanted! There is a need for input and help from others. label Apr 13, 2020
loup99 added a commit that referenced this issue Jul 3, 2020
@loup99
Dynasty File Changes #139
426f266 
- Moved the dynasties added by WtWSMS to the WtWSMS file
loup99 added a commit that referenced this issue Jul 6, 2020
@loup99
Briton Character Reorganisation #139
169e281 
- Moved Briton characters in the Welsh file to the Briton file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted! There is a need for input and help from others. History Everything in relation to history.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rquinio @loup99