-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rv_core_ibex] Improve V2(S) pass rates #18421
Comments
I don't think we need to improve the pass rates in any of these tests for M2.5.1. There's no failures that look concerning and they generally relate to co-sim/ibex mismatches in some tricky corner cases where there's multiple possible correct behaviours. |
@GregAC is planning to triage the coverage issues and determine if this issue can be moved to the backlog as part of the rv_core_ibex V2.5 sign-off. |
This will move to the backlog and be complete for V3. The failures here are all thought to be verification environment related. They typically relate to complex cases around interrupts/exceptions/debug requests in particular. Here both Ibex and Spike do spec compliant things but don't always match, further work is needed to the co-simulation environment to bring them into alignment (a common issue is precise timing of when things like interrupts are signalled to spike). |
@GregAC to document known issues and coverage gaps in DV, and decide if this is something we can land as part of M5. |
@johngt this issue is aiming to track post M4/V2(S) work so re-opening. |
@GregAC mentioned to have a PR almost ready to bring the pass rates further up. I am thus adjusting the effort left. Please correct the effort spent if you disagree Greg. |
A deep dive regression triage of all Ibex regression failures is here: lowRISC/ibex#2187 As part of this work some of the failures have been addressed and the most recent nightly run https://ibex.reports.lowrisc.org/opentitan/ibex-regr-report-04-07-2024.html has a 98.1% pass rate. |
Thanks @GregAC for your report on the deep dive regression triage. I've reviewed it and confirm that the observed issues are not concerning but rather well understood testbench / co-simulation issues which are in most cases tedious to fix. There was one RTL bug identified which isn't critical and for which a workaround exists, see lowRISC/ibex#2186. We can keep this issue open to keep track of these failures or close it as they are tracked in the Ibex repo. I let @GregAC take the decision. If we leave it open, we should move it to M7 probably. |
After discussing with @GregAC , we've decided to move this to M7. For M5, all relevant work is done. |
Description
V2 tests that require fixing to 90% pass rate (passing/total):
V2S tests that require fixing to 90% pass rate (passing/total):
Estimate from scoping 3-6d
The text was updated successfully, but these errors were encountered: