Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rv_core_ibex] Improve V2(S) pass rates #18421

Open
9 tasks
johngt opened this issue May 8, 2023 · 10 comments
Open
9 tasks

[rv_core_ibex] Improve V2(S) pass rates #18421

johngt opened this issue May 8, 2023 · 10 comments
Assignees
Labels
Component:DV DV issue: testbench, test case, etc. Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:rv_core_ibex

Comments

@johngt
Copy link

johngt commented May 8, 2023

Description

V2 tests that require fixing to 90% pass rate (passing/total):

  • Riscv_debug_branch_jump_test (8/10)
  • Riscv_dret_test (1/5)
  • Riscv_debug_ebreakmu_test (11/15)
  • Riscv_assorted_traps_interrupts_debug_test (4/10)
  • Riscv_interrupt_wfi_test (12/15)
  • Riscv_pmp_out_of_bounds_test (39/50)
  • Riscv_epmp_mmwp_test (14/20)
    V2S tests that require fixing to 90% pass rate (passing/total):
  • Riscv_pc_intg_test (11/15)
  • Riscv_mem_intg_error_test (12/15)

Estimate from scoping 3-6d

estimate 24

@GregAC
Copy link
Contributor

GregAC commented May 9, 2023

I don't think we need to improve the pass rates in any of these tests for M2.5.1. There's no failures that look concerning and they generally relate to co-sim/ibex mismatches in some tricky corner cases where there's multiple possible correct behaviours.

@moidx
Copy link
Contributor

moidx commented Jun 15, 2023

@GregAC is planning to triage the coverage issues and determine if this issue can be moved to the backlog as part of the rv_core_ibex V2.5 sign-off.

@GregAC
Copy link
Contributor

GregAC commented Jun 22, 2023

This will move to the backlog and be complete for V3. The failures here are all thought to be verification environment related. They typically relate to complex cases around interrupts/exceptions/debug requests in particular. Here both Ibex and Spike do spec compliant things but don't always match, further work is needed to the co-simulation environment to bring them into alignment (a common issue is precise timing of when things like interrupts are signalled to spike).

@msfschaffner msfschaffner added the Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones label Oct 7, 2023
@msfschaffner msfschaffner changed the title [rv_core_ibex] Tests to V2(S) level [rv_core_ibex] Improve V2(S) pass rates Jan 26, 2024
@moidx
Copy link
Contributor

moidx commented Jun 7, 2024

@GregAC to document known issues and coverage gaps in DV, and decide if this is something we can land as part of M5.

@johngt
Copy link
Author

johngt commented Jun 10, 2024

@moidx - this issue has been superseded by #23542
Going to close this as the efforts for regressions etc are captured there.

@johngt johngt closed this as completed Jun 10, 2024
@GregAC
Copy link
Contributor

GregAC commented Jun 10, 2024

@johngt this issue is aiming to track post M4/V2(S) work so re-opening.

@GregAC GregAC reopened this Jun 10, 2024
@vogelpi
Copy link
Contributor

vogelpi commented Jun 27, 2024

@GregAC mentioned to have a PR almost ready to bring the pass rates further up. I am thus adjusting the effort left. Please correct the effort spent if you disagree Greg.

@GregAC
Copy link
Contributor

GregAC commented Jul 4, 2024

A deep dive regression triage of all Ibex regression failures is here: lowRISC/ibex#2187

As part of this work some of the failures have been addressed and the most recent nightly run https://ibex.reports.lowrisc.org/opentitan/ibex-regr-report-04-07-2024.html has a 98.1% pass rate.

@vogelpi
Copy link
Contributor

vogelpi commented Jul 5, 2024

Thanks @GregAC for your report on the deep dive regression triage. I've reviewed it and confirm that the observed issues are not concerning but rather well understood testbench / co-simulation issues which are in most cases tedious to fix. There was one RTL bug identified which isn't critical and for which a workaround exists, see lowRISC/ibex#2186.

We can keep this issue open to keep track of these failures or close it as they are tracked in the Ibex repo. I let @GregAC take the decision. If we leave it open, we should move it to M7 probably.

@vogelpi
Copy link
Contributor

vogelpi commented Jul 9, 2024

After discussing with @GregAC , we've decided to move this to M7. For M5, all relevant work is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:DV DV issue: testbench, test case, etc. Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:rv_core_ibex
Projects
None yet
Development

No branches or pull requests

5 participants