Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check path compatibility with Windows #14

Open
quantumjot opened this issue Jan 31, 2022 · 1 comment
Open

check path compatibility with Windows #14

quantumjot opened this issue Jan 31, 2022 · 1 comment
Assignees
@nthndy
Labels
bug Something isn't working

Comments

@quantumjot
Copy link
Collaborator

In several places, paths are constructed using f-strings. We might need to check that these work on Windows. Better to use pathlib (or os.path.join) to ensure cross-platform compatibility.
@quantumjot quantumjot added the bug Something isn't working label Jan 31, 2022
@nthndy
Copy link
Contributor

nthndy commented Jan 31, 2022

yeah i ended up testing a bit of this on friday with manasi and you are correct! will wrap all f-strings in the Path function from pathlib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nthndy nthndy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quantumjot @nthndy