Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos not always blocked, gifs not blocked, images not blocked? #28

Open
user0022 opened this issue Jan 22, 2023 · 0 comments
Open

Videos not always blocked, gifs not blocked, images not blocked? #28

user0022 opened this issue Jan 22, 2023 · 0 comments

Comments

@user0022
Copy link

Hello, thank you for your extension. But I just installed it and it didn't seem to work well.
I use Firefox, under Lubuntu 22.04.


VIDEOS.

I made a test on Youtube.
First it seemed to work, then just visiting a Youtuber's page, I heard the voice of a video!
Simply being first in its homepage, I went to the About page, then came back in the homepage, and it is here that the video had begun to play. So at first page opening it was OK, but at second opening the blocking didn't work anymore.
An extension like Image Video Block doesn't have this problem, so as its code is open source, maybe you could check it for fixing yours, but I'm not a developper, I don't know, I said it just in case it helps.

A possible explanation I imagined (?).
When Click to load a video and even Block Medias are on (o)True, then one could expect is will stay blocked, but no because Custom attributes for html element can invalidate/disable it maybe.

So problem comes maybe from features (not-)conditionalities being a bit contradictory or conflicting or redundant?
Maybe Click to load a video could be displayed as an option of Block Medias, and could be disabled (in grey) if Block Medias is (o)False. If a media is not blocked, it loads (and maybe plays). If it is blocked, it has the optional possibility with a click to load and play. It would be either one or the other, if one allows second, it's allowed, but if it doesn't, it is not allowed. So prevent the Click to load a video when it is blocked could prevent the playing that I saw?
Maybe also the conflict (if exists) is with Custom attributes for html element instead of Click to load a video (or both).
Or something else, I'm a bit lost.


GIF.

GIF play and loop without hovering here https://www.localcdn.org/tutorial and maybe everywhere.


IMAGES.

I also noticed many (all?) images were still here, though Block Images was on (o)True.
Is it worth indicating a page? As it seems to be like this almost everywhere.
A bit like videos, maybe Image quality disables Block Images
But as I don't know much coding, maybe it is because not all images are between tags.


Maybe oyher features don't work either, or also it's me who don't understand how this extension works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant