Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distribute control TangoDS as a conda package #4

Closed
lrlunin opened this issue Feb 18, 2023 · 6 comments
Closed

distribute control TangoDS as a conda package #4

lrlunin opened this issue Feb 18, 2023 · 6 comments

Comments

@lrlunin
Copy link
Owner

lrlunin commented Feb 18, 2023

there is even better way to make the installation easier. Since we do not need zmqServer and only slsReceiver we can migrate to the sls software conda distribtuion instead of compiling the package by ourself. Then it would be enough to only create an environment with all required packages:

conda create -n moench_detector python=3.10 slsdet=6.1.2 slsdetlib=6.1.2 tangoControlDevice tangoZMQDevice 
@lrlunin
Copy link
Owner Author

lrlunin commented Feb 19, 2023

Distribution of this package itself should not be an issue. Nevertheless, detectors required config files (depends of the networking configuration and detector's generation. The path to these files is given as tango property and can be changed any time.

Image

The question is how to track/backup these config files?

Previously we have stored them in the same forked repository of sls package. I believe it's still a good idea to git these files and even assign them tags. Their layouts and syntax is dependent from firmware's and sls software's versions and should match the right one.

Then the user would still need to download these configs with a separate command but I believe it's still a significant simplification of the installation process in comparison with building c++ project and python libs from source.

Any thoughts or proposals @dschick ?

@lrlunin
Copy link
Owner Author

lrlunin commented Feb 19, 2023

In this tango DS we are also dependent from the sls package executables as slsReceiver and python bindings to configure the detector. These are already available in conda. We also often use a virtual detector for debugging and it's missing. See the issues slsdetectorgroup/slsDetectorPackage#675

@lrlunin
Copy link
Owner Author

lrlunin commented Feb 20, 2023

@lrlunin
Copy link
Owner Author

lrlunin commented Feb 22, 2023

issue was resolved and lied on the wrong merged version to the fork:
MBI-Div-B/moench-slsDetectorGroup@c2fd2a3

the last release (which is used for the real detektor) though
MBI-Div-B/moench-slsDetectorGroup@7f4b753
is working fine as expected

@lrlunin
Copy link
Owner Author

lrlunin commented Feb 22, 2023

the next step is to test the build with the 7.0.0 version.

  • check compatibility
  • check nanoseconds readout from python

@lrlunin
Copy link
Owner Author

lrlunin commented Mar 1, 2023

resolved in 9f5007a

@lrlunin lrlunin closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant