Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Review from Weekly PR Summary #117

Closed
DominikRemo opened this issue Oct 14, 2024 · 1 comment · Fixed by #118
Closed

Missing Review from Weekly PR Summary #117

DominikRemo opened this issue Oct 14, 2024 · 1 comment · Fixed by #118
Assignees
Labels
application-server bug Something isn't working priority:critical Urgent tasks needing immediate resolution.

Comments

@DominikRemo
Copy link

Describe the bug
The tool does not count my review for the following Pull Request, despite it being completed within the relevant time frames: PR Review Link. This review should have been counted for CW 41 but is not accounted for (it is also missing from CW 42).

To Reproduce
Steps to reproduce the behavior:

  1. Go to the tool’s summary page for CW 41 and CW 42.
  2. Check the list of counted reviews.
  3. Search for the reviewer (Dominik Remo) associated with The PR Review
  4. The review is missing from the counted reviews in both weeks.

Expected behavior
The review for the PR should have been counted towards my total review score for CW 41.

Additional context
This issue may impact the accuracy of review scores and could affect multiple users. The review was completed and visible on GitHub, but the tool failed to recognize it for scoring. It might be useful to check the review processing logic or any filters applied when counting reviews in weekly summaries.

@GODrums
Copy link
Contributor

GODrums commented Oct 14, 2024

Thank you for informing us!

We were made aware of this issue earlier today and are working with highest priority on fixing this! I am currently testing possible solutions in #118.

We will make an additional post on Slack as soon as the fix has been pushed.

@GODrums GODrums linked a pull request Oct 14, 2024 that will close this issue
12 tasks
@GODrums GODrums added bug Something isn't working application-server priority:critical Urgent tasks needing immediate resolution. labels Oct 14, 2024
@GODrums GODrums self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application-server bug Something isn't working priority:critical Urgent tasks needing immediate resolution.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants