Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security update popup? #1308

Open
Lex-DRL opened this issue Dec 7, 2024 · 2 comments
Open

Security update popup? #1308

Lex-DRL opened this issue Dec 7, 2024 · 2 comments

Comments

@Lex-DRL
Copy link

Lex-DRL commented Dec 7, 2024

Today, I've noticed a changelog message for ComfyUI v0.3.7 warning users about ultralytics 8.3.41-8.3.42 vulnerability. I was lucky to: 1) going to Comfy, 2) deciding to update and 3) deciding to read the changelog at the very exact time this was there. But it could be easily missed, especially if you don't use ComfyUI every day and therefore can jump over entire versions between updates.

Maybe, ComfyUI and Manager need to figure out a way to communicate security-related or any other critical changelog messages and Manager should show them in a special "warning" popup, which is much harder to miss?

Probably, this in-page notifier needs to scan over ALL the messages which appeared since the last update (anything after the local commit the user's install is at).

@Lex-DRL
Copy link
Author

Lex-DRL commented Dec 7, 2024

To avoid any ambiguity, this is what I'm talking about:
screenshot

@ltdrdata
Copy link
Owner

ltdrdata commented Dec 8, 2024

I’m already considering such a method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants