Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI should exit with non-zero return code when failed. #1314

Open
the729 opened this issue Dec 9, 2024 · 1 comment
Open

CLI should exit with non-zero return code when failed. #1314

the729 opened this issue Dec 9, 2024 · 1 comment

Comments

@the729
Copy link

the729 commented Dec 9, 2024

The current behavior of cm-cli.py is to log error and continue, when it encounters any error during installation of custom nodes, i.e. git clone failed or pip install failed.

This behaviour is not optimal for using in docker build, as the container builder will think it has succeeded.

Can we add a flag to make it abort installation if any errors happened?

@ltdrdata
Copy link
Owner

Ok. I'll add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants