Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab9 Review Raffaele Viola - s309063 #6

Open
RaffaeleViola opened this issue Dec 10, 2023 · 0 comments
Open

Lab9 Review Raffaele Viola - s309063 #6

RaffaeleViola opened this issue Dec 10, 2023 · 0 comments

Comments

@RaffaeleViola
Copy link

Your code is well written and structured. The readme file is also pretty clear.

Here are some considerations about your work:

  • You could create a class Individual or a similar data structure in order to save the fitness computation of the elite/parent individuals and avoid to recompute it at every step
  • A better improvements for the fitness calls would be to create an hash map (python dictionary) and store as a key the genome of the individuals generated (you can use a tuple as key because it is natively hash-able) and as value the fitness. In this way you could avoid to recompute the fitness for already seen individuals.
  • You could try to use different type of crossover other than the one cut. For instance you could use the uniform crossover that should be useful with a wide genome like the one of this problem.

Overall good job, the model is standard but effective enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant