Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SETUP ISSUE] failed activation, invalid Chrome binary #694

Closed
iateadonut opened this issue Feb 9, 2024 · 4 comments
Closed

[SETUP ISSUE] failed activation, invalid Chrome binary #694

iateadonut opened this issue Feb 9, 2024 · 4 comments

Comments

@iateadonut
Copy link
Contributor

iateadonut commented Feb 9, 2024

Hi,

I'm working to set this up on an existing plugin directory.

I have a few issues:

  1. I get this error:
Could not activate plugin: Undefined variable $wpdb 

In order to track it down, I needed a stack trace or at least a file and line.

So I added:

$this->say($activationResult->getFile() . ":" . $activationResult->getLine());

I've created a pull request:
#693

 Installing Chromedriver ...
 Invalid Chrome binary: not executable or not existing. 

It looks like an issue here:

private function detectBinary(): string

I have chromium and chromedriver installed on my localhost. I wonder if chromium will work? If so, should i create a method detectLinuxBinaryPath()? It would check 'which {exe}' for a list of executables in the order "google-chrome", 'chromium' and whatever else, if chromedriver would work. Let me know.

Just to re-iterate, my question is: which linux binaries will work for the chrome binary besides google-chrome?

@iateadonut
Copy link
Contributor Author

also made this pull request: #695

@lucatume lucatume changed the title [SETUP ISSUE] [SETUP ISSUE] failed activation, invalid Chrome binary Feb 9, 2024
@lucatume
Copy link
Owner

lucatume commented Feb 9, 2024

@iateadonut thanks for the issue and the PRs.
I've filled in the issue title for you, I would ask you to fill it the next time.
Again, next time, file two issues to keep the specificity and allow better searching and tracking.

@lucatume
Copy link
Owner

I've merged #693, thanks.
I will look into #695 next.

@lucatume
Copy link
Owner

Merged #695 and released.
Thanks again for your PR and for taking the time to open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants