Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No game over #1

Open
starry-abyss opened this issue Jan 10, 2017 · 5 comments
Open

No game over #1

starry-abyss opened this issue Jan 10, 2017 · 5 comments

Comments

@starry-abyss
Copy link

Hi, there is no game over in the port, lives can go negative :-)

@casensiom
Copy link
Member

Did you have this issue?

On the kill method (inside jean.js) the method Abbaye.STATES.game.afterKillHero(); is invoked.
Inside this method Abbaye.STATES.sequence.run(Abbaye.Sequence.GAME_OVER); is invoked.

Remember that javascript is not multithread! ;D

@starry-abyss
Copy link
Author

Hmm, yes, but I naively thought it was always reproducible. Happened it the middle of the game.
Also when I started the game right now I spawned near the dragon, and only after dying - in the beginning.
As a guess, maybe the health is checked ==0 and not <=0?

Oh, I see there are some debug keys enabled, I might have pressed one of them? :D

@casensiom
Copy link
Member

Can you provide more info so I can try to reproduce the bugs?
In which computer/device? Which browser? What URL are you using? ...

Thank you.

@starry-abyss
Copy link
Author

Not much, I just played it, visited many rooms until I lost all the lives. And then the counter just continued to decrement each death, no matter it was negative.
Firefox 50.1. Win 7 64 bit. http://www.lucera-project.com/products/abbaye/

Not at all, I think my info is nearly useless. :(
If there is some invincibility debug key, then I probably just pressed it accidentally

Also, the game is a bit blurred, texts are sometimes cut (see the image), and sprites suffer from the artifacts like the lines to left of the knights (on the image):
default

Sorry for putting everything in one ticket...

@casensiom
Copy link
Member

I appreciate your feedback.

There's a debug key 'D', that sets you in 'god mode' but should not change anything more.

Not sure why you have this behavior. I will add some sanity checks.

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants