-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@polka/url] Incorrect query params parsing when param contains encoded "&" #150
Labels
Comments
Line 32 in 3b4d866
This line decode the url too early causing the encoded |
Also incorrect query param parsing if param contains |
lukeed
added a commit
that referenced
this issue
May 23, 2021
* break(url): handle decodes correctly; remove output keys; - Closes #150 * chore(url): update readme * break(url): use named `parse` export * fix(polka): rebuild `req.url` manually; - includes decoded `req.path` and ENCODED `req.search` segments * fix(polka): adjust `Request` types * chore(url): update benchmark * chore(url): update benchmark results * chore(url): add "raw performance" results * chore: linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Consider the url below:
@polka/url
parse the above into:which is incorrect.
Reproduction
The text was updated successfully, but these errors were encountered: