Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Exposed members on Polka class #209

Open
43081j opened this issue Jun 26, 2024 · 0 comments
Open

[question] Exposed members on Polka class #209

43081j opened this issue Jun 26, 2024 · 0 comments

Comments

@43081j
Copy link

43081j commented Jun 26, 2024

As part of some migrations, i've noticed myself needing the following members from Polka:

  • Polka#handler - so i can bind it to request myself rather than calling listen
  • wares - i want to create a new Polka which has the same middleware stack as another. for now i've literally set b.wares = a.wares but maybe we should have a method for this?
  • onError - i want to set the error handler after instantiating Polka

basically, can i rely on these 3 things being part of the public interface? (i.e. you won't remove them without a new major)

and if not, what could we introduce to cover the same use cases in a supported way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant