From 216c86c151946e7470f6637538be0f38a38be8a8 Mon Sep 17 00:00:00 2001 From: CJ42 Date: Mon, 9 Oct 2023 11:38:36 +0100 Subject: [PATCH] perf: remove double `_exist` check in LSP8Core --- .../LSP8IdentifiableDigitalAssetCore.sol | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/contracts/LSP8IdentifiableDigitalAsset/LSP8IdentifiableDigitalAssetCore.sol b/contracts/LSP8IdentifiableDigitalAsset/LSP8IdentifiableDigitalAssetCore.sol index 97ac6b16f..291551904 100644 --- a/contracts/LSP8IdentifiableDigitalAsset/LSP8IdentifiableDigitalAssetCore.sol +++ b/contracts/LSP8IdentifiableDigitalAsset/LSP8IdentifiableDigitalAssetCore.sol @@ -285,6 +285,7 @@ abstract contract LSP8IdentifiableDigitalAssetCore is ) internal virtual { bool isRemoved = _operators[tokenId].remove(operator); if (!isRemoved) revert LSP8NonExistingOperator(operator, tokenId); + emit RevokedOperator( operator, tokenOwner, @@ -368,10 +369,6 @@ abstract contract LSP8IdentifiableDigitalAssetCore is revert LSP8CannotSendToAddressZero(); } - if (_exists(tokenId)) { - revert LSP8TokenIdAlreadyMinted(tokenId); - } - _beforeTokenTransfer(address(0), to, tokenId); // Check that `tokenId` was not minted inside the `_beforeTokenTransfer` hook