From 607145a2c7138c94fc8c8c363a6579e82b83b03b Mon Sep 17 00:00:00 2001
From: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
Date: Wed, 24 Jan 2024 14:38:54 +0000
Subject: [PATCH] ci: remove import require tests for testing constant imports
 (#859)

---
 .github/workflows/build-lint-test.yml |   3 -
 package.json                          |   1 -
 tests/importRequire.sh                | 148 --------------------------
 3 files changed, 152 deletions(-)
 delete mode 100755 tests/importRequire.sh

diff --git a/.github/workflows/build-lint-test.yml b/.github/workflows/build-lint-test.yml
index 184e7c874..4355625a2 100644
--- a/.github/workflows/build-lint-test.yml
+++ b/.github/workflows/build-lint-test.yml
@@ -47,9 +47,6 @@ jobs:
             contracts.ts
           key: ${{ github.run_id }}
 
-      - name: 🧪 run import/requires tests
-        run: npm run test:importRequire
-
       - name: 📚 generate ABI docs
         run: npm run build:docs
 
diff --git a/package.json b/package.json
index b07a1fa0f..33e7d816b 100644
--- a/package.json
+++ b/package.json
@@ -104,7 +104,6 @@
     "test:reentrancy": "hardhat test --no-compile tests/Reentrancy/Reentrancy.test.ts",
     "test:reentrancyinit": "hardhat test --no-compile tests/Reentrancy/ReentrancyInit.test.ts",
     "test:foundry": "forge test --no-match-test Skip -vvv --gas-report > gasreport.ansi",
-    "test:importRequire": "npm run build:js && ./tests/importRequire.sh",
     "test:turbo": "turbo test"
   },
   "dependencies": {
diff --git a/tests/importRequire.sh b/tests/importRequire.sh
deleted file mode 100755
index b3f7e7e9a..000000000
--- a/tests/importRequire.sh
+++ /dev/null
@@ -1,148 +0,0 @@
-#!/usr/bin/env bash
-rm -rf ./.test
-mkdir ./.test
-testdir="$(pwd)/.test"
-trap "rm -rf $testdir" EXIT
-RED="\033[31m"
-GREEN="\033[32m"
-YELLOW="\033[33m"
-ENDCOLOR="\033[0m"
-
-if [ ! -f './dist/constants.cjs' ]
-then
-  echo -e "${RED}Fail: No constants.cjs found${ENDCOLOR}"
-  exit 1
-fi
-if [ ! -f './dist/constants.mjs' ]
-then
-  echo -e "${RED}Fail: No constants.mjs found${ENDCOLOR}"
-  exit 1
-fi
-if [ ! -f './package.json' ]
-then
-  echo -e "${RED}Fail: No package.json found${ENDCOLOR}"
-  exit 1
-fi
-
-echo -e "${YELLOW}Packaging npm package${ENDCOLOR}"
-npm pack
-
-PACK="$(pwd)/$(ls | grep -E "^lukso.*tgz$")"
-if [ ! -f "$PACK" ]
-then
-  echo -e "${RED}Fail: No tgz pack file found${ENDCOLOR}"
-  exit 1
-fi
-
-echo -e "${YELLOW}Creating test directory${ENDCOLOR}"
-cd ./.test
-
-echo -e "${YELLOW}Creating package.json type=module${ENDCOLOR}"
-cat > package.json <<EOF
-{
-  "type": "module",
-  "devDependencies": {
-    "typescript": "^4.3.5"
-  },
-  "scripts": {
-    "build": "tsc"
-  }
-}
-EOF
-npm install
-
-echo -e "${YELLOW}Installing $PACK"
-npm install "$PACK"
-
-echo -e "${YELLOW}Creating cjs require test${ENDCOLOR}"
-cat > test.cjs <<EOF
-const pkg = require('@lukso/lsp-smart-contracts/package.json');
-if (pkg.version) {
-  console.log("\x1b[32mSuccess: require package.json\x1b[0m");
-} else {
-  console.log("\x1b[31mFail: require package.json has no version property\x1b[0m");
-  process.exit(1);
-}
-const { INTERFACE_IDS } = require('@lukso/lsp-smart-contracts');
-if (INTERFACE_IDS) {
-  console.log("\x1b[32mSuccess: require { INTERFACE_IDS }\x1b[0m");
-} else {
-  console.log("\x1b[31mFail: require { INTERFACE_IDS } does not yield an object\x1b[0m");
-  process.exit(1);
-}
-EOF
-
-echo -e "${YELLOW}Executing cjs require test${ENDCOLOR}"
-if ! node test.cjs
-then
-  echo "${RED}Fail: require failed${ENDCOLOR}"
-  exit 1
-fi
-
-echo -e "${YELLOW}Creating esm (ts) import test${ENDCOLOR}"
-cat > test.ts <<EOF
-import pkg from '@lukso/lsp-smart-contracts/package.json' assert { type: 'json' };
-if (pkg.version) {
-  console.log("\x1b[32mSuccess: import package.json\x1b[0m");
-} else {
-  console.log("\x1b[31mFail: import package.json has no version property\x1b[0m");
-  process.exit(1);
-}
-import { INTERFACE_IDS } from '@lukso/lsp-smart-contracts';
-if (INTERFACE_IDS) {
-  console.log("\x1b[32mSuccess: import { INTERFACE_IDS }\x1b[0m");
-} else {
-  console.log("\x1b[31mFail: import { INTERFACE_IDS } does not yield an object\x1b[0m");
-  process.exit(1);
-}
-EOF
-
-echo -e "${YELLOW}Creating tsconfig.json to allow json import${ENDCOLOR}"
-cat > tsconfig.json <<EOF
-{
-  "compilerOptions": {
-    "target": "ES2022",
-    "module": "esnext",
-    "strict": true,
-    "outDir": "dist",
-    "jsx": "preserve",
-    "importHelpers": true,
-    "moduleResolution": "nodenext",
-    "noImplicitAny": true,
-    "experimentalDecorators": true,
-    "skipLibCheck": true,
-    "allowSyntheticDefaultImports": true,
-    "sourceMap": true,
-    "allowJs": true,
-    "baseUrl": ".",
-    "lib": [
-      "ES2018",
-      "dom",
-      "dom.iterable",
-      "scripthost"
-    ],
-    "resolveJsonModule": true
-  },
-  "include": [
-    "./*.ts",
-    "./node_modules/@lukso/lsp-smart-contracts/**/*.ts",
-    "./node_modules/@lukso/lsp-smart-contracts/**/*.js",
-    "./node_modules/@lukso/lsp-smart-contracts/**/*.json"
-  ]
-}
-EOF
-
-echo -e "${YELLOW}Testing import${ENDCOLOR}"
-if ! npx esbuild test.ts --bundle --outfile=dist/test.mjs
-then
-  echo "${RED}Fail: import failed${ENDCOLOR}"
-  exit 1
-fi
-ls dist
-
-echo -e "${YELLOW}Testing import${ENDCOLOR}"
-if ! node dist/test.mjs
-then
-  echo "${RED}Fail: import failed${ENDCOLOR}"
-  exit 1
-fi