From 892c2d11a1551bd6fbe8df3fbbd13d1e90800a65 Mon Sep 17 00:00:00 2001 From: CJ42 Date: Wed, 28 Feb 2024 17:34:08 -0700 Subject: [PATCH] ci: disable temporarily foundry gas report in CI --- .github/workflows/foundry-tests.yml | 30 +++++++++++------------ packages/lsp-smart-contracts/package.json | 2 +- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/.github/workflows/foundry-tests.yml b/.github/workflows/foundry-tests.yml index b0789c51d..0f450fc69 100644 --- a/.github/workflows/foundry-tests.yml +++ b/.github/workflows/foundry-tests.yml @@ -36,18 +36,18 @@ jobs: # due to non-deterministic fuzzing (but still use pseudo-random fuzzing seeds) FOUNDRY_FUZZ_SEED: 0x${{ github.event.pull_request.base.sha || github.sha }} - - name: Compare gas reports - uses: Rubilmax/foundry-gas-diff@v3.13.1 - with: - summaryQuantile: 0.9 # only display the 10% most significant gas diffs in the summary (defaults to 20%) - sortCriteria: avg,max # sort diff rows by criteria - sortOrders: desc,asc # and directions - id: gas_diff - - - name: Add gas diff to sticky comment - if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target' - uses: marocchino/sticky-pull-request-comment@v2 - with: - # delete the comment in case changes no longer impact gas costs - delete: ${{ !steps.gas_diff.outputs.markdown }} - message: ${{ steps.gas_diff.outputs.markdown }} + # - name: Compare gas reports + # uses: Rubilmax/foundry-gas-diff@v3.13.1 + # with: + # summaryQuantile: 0.9 # only display the 10% most significant gas diffs in the summary (defaults to 20%) + # sortCriteria: avg,max # sort diff rows by criteria + # sortOrders: desc,asc # and directions + # id: gas_diff + + # - name: Add gas diff to sticky comment + # if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target' + # uses: marocchino/sticky-pull-request-comment@v2 + # with: + # # delete the comment in case changes no longer impact gas costs + # delete: ${{ !steps.gas_diff.outputs.markdown }} + # message: ${{ steps.gas_diff.outputs.markdown }} diff --git a/packages/lsp-smart-contracts/package.json b/packages/lsp-smart-contracts/package.json index 07a6bf898..d504eb7e3 100644 --- a/packages/lsp-smart-contracts/package.json +++ b/packages/lsp-smart-contracts/package.json @@ -60,7 +60,7 @@ "lint:solidity": "solhint 'contracts/**/*.sol' && prettier --check 'contracts/**/*.sol'", "package": "hardhat prepare-package", "test": "hardhat test --no-compile tests/**/*.test.ts", - "test:foundry": "FOUNDRY_PROFILE=lsp_smart_contracts forge test --no-match-test Skip -vvv --gas-report > gasreport.ansi", + "test:foundry": "FOUNDRY_PROFILE=lsp_smart_contracts forge test --no-match-test Skip -vvv", "test:coverage": "hardhat coverage" }, "dependencies": {