From 58ef9e92de9929acdc77f77a845383af667b2bb4 Mon Sep 17 00:00:00 2001 From: Alex Danoff Date: Thu, 25 May 2023 13:22:56 -0700 Subject: [PATCH] W3CPointerEvents: add missing attributes to pointer events (#37537) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/37537 Changelog: [Internal] [Changed] - W3CPointerEvents: add missing attributes to pointer events The [PointerEvent interface](https://www.w3.org/TR/pointerevents/#pointerevent-interface) includes some additional properties which we weren't including in the events we dispatched. This diff adds them (set to default values): - twist - tangentialPressure In the future, we can try to set reasonable values for these properties based on the underlying native events. Reviewed By: NickGerleman Differential Revision: D45747033 fbshipit-source-id: 529f9d90299f33bc04eae3fb85ddd7eac3d61c5b --- .../java/com/facebook/react/uimanager/events/PointerEvent.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/PointerEvent.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/PointerEvent.java index 9b5bc00a973376..0e298829a55eee 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/PointerEvent.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/PointerEvent.java @@ -222,6 +222,8 @@ private WritableMap createW3CPointerEvent(int index) { pointerEvent.putDouble("tiltX", 0); pointerEvent.putDouble("tiltY", 0); + pointerEvent.putInt("twist", 0); + if (pointerType.equals(PointerEventHelper.POINTER_TYPE_MOUSE)) { pointerEvent.putDouble("width", 1); pointerEvent.putDouble("height", 1); @@ -241,6 +243,7 @@ private WritableMap createW3CPointerEvent(int index) { pointerEvent.putDouble( "pressure", PointerEventHelper.getPressure(pointerEvent.getInt("buttons"), mEventName)); + pointerEvent.putDouble("tangentialPressure", 0.0); return pointerEvent; }