Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison #1

Open
DrSnuggles opened this issue Jan 7, 2024 · 3 comments
Open

Comparison #1

DrSnuggles opened this issue Jan 7, 2024 · 3 comments

Comments

@DrSnuggles
Copy link

DrSnuggles commented Jan 7, 2024

Hi,

2 years ago i ported some AY emulators from ScriptNodeProcessor to AudioWorklet.
2 days ago i found your AY emulation and i think it sounds great.

For easier comparison and some kind of evidence i ported yours to AudioWorklet as well to add it in my player.
Added different panning modes but also dismissed the WebAudio BiQuad filters for a quick result.

Compare yourself:
https://drsnuggles.github.io/AYSir

EDIT:

  • Switched to next iteration of my visualizer (no need for previous hint on how to enable viz)
  • Added different stereo mode pannings as drop down
@lunarjournal
Copy link
Owner

lunarjournal commented Jan 7, 2024

Hi @DrSnuggles

That is really cool! Never thought anyone would use my little AY emulator (I wrote it for fun).
I really like your player though. It's interesting to see how my emulator compares to others.

Thanks for your work!

By the way I think the FIR filter needs some tuning. I need to update https://github.com/lunarjournal/emu8910/blob/main/emu8910.js#L4 for a more responsive bass (I used https://www.arc.id.au/FilterDesign.html)

@lunarjournal
Copy link
Owner

lunarjournal commented Jan 29, 2024

Hey @DrSnuggles

I've made a simple but noticeable change with the way the FIR filter calculations are done.

bf64932

I've compared it to Ayumi and it sounds a lot better now. The audio is much clearer compared to the others.
What are your thoughts?

You might want to update AYSir with the latest changes to the emulator.

PS
Also by emulator name you can put "emu8910" instead of "LunarJournal". Just a recommendation

Thanks!

@DrSnuggles
Copy link
Author

Just added your change, had not that much time to listen to many songs but again your emu8910 sounds best of all.
Actually it's my favourite 8910 emulation.

For the emulator name i choosed to name it by the source/author since all do emulate 8910. So it's nicer for others to find the specific one.

Thanks for update and information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants