Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we exclude datasets where the simulated network has worse BIC than the raxml-ng best tree? #40

Open
lutteropp opened this issue Jan 17, 2021 · 3 comments

Comments

@lutteropp
Copy link
Owner

lutteropp commented Jan 17, 2021

It sometimes happens that the simulated network is rejected by BIC, in favor of the best tree inferred by raxml-ng. What should we do with these datasets?

A) Include them in our experiments, wasting hours on NetRAX calls that will infer a tree anyway.
B) Re-simulate the dataset if this happens. Do not run NetRAX on it. Keep the problematic dataset in an extra folder (to use for post-analysis of simulation parameters).
C) Re-simulate the dataset if this happens. Do not run NetRAX on it. Discard the problematic dataset.

I vote for B. (Or C, if we are ok with "well, likely it was an ultrametric network with a fake reticulation again")

@lutteropp lutteropp reopened this Jan 18, 2021
@lutteropp
Copy link
Owner Author

(reopened because this still happens from time to time. It was not just due to some bug)

@lutteropp
Copy link
Owner Author

Or we can go with A, add writing to a logfile to NetRAX, and then post-evaluate whether NetRAX did encounter the correct network and just discarded it due to BIC issues.

@stamatak
Copy link
Collaborator

stamatak commented Jan 19, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants