Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keeps failing at libmediainfo x64 build #2723

Closed
jamiesaun85 opened this issue Jun 19, 2024 · 20 comments
Closed

keeps failing at libmediainfo x64 build #2723

jamiesaun85 opened this issue Jun 19, 2024 · 20 comments

Comments

@jamiesaun85
Copy link

Paste output of the suite here

logs.zip

@jamiesaun85 jamiesaun85 changed the title keeps failing at m keeps failing at libmediainfo x64 build Jun 19, 2024
@jamiesaun85
Copy link
Author

┌ mediainfo git ......................................... [Updates found]
├ Running autogen...
├ Running configure...
Likely error (tail of the failed operation logfile):
checking if ccache g++ PIC flag -DDLL_EXPORT -DPIC works... yes
checking if ccache g++ static flag -static works... yes
checking if ccache g++ supports -c -o file.o... yes
checking if ccache g++ supports -c -o file.o... (cached) yes
checking whether the ccache g++ linker (C:/ab-suite/msys64/mingw64/x86_64-w64-mingw32/bin/ld.exe) supports shared libraries... yes
checking dynamic linker characteristics... Win32 ld.exe
checking how to hardcode library paths into programs... immediate
./configure: line 16929: libzen-config: command not found
./configure: line 17028: libmediainfo-config: command not found
configure: error: libmediainfo configuration is not found
configure failed. Check C:/ab-suite/build/mediainfo-git/Project/GNU/CLI/ab-suite.configure.log
This is required for other packages, so this script will exit.
Creating diagnostics file...

Attach C:\ab-suite\build\logs.zip to the GitHub issue.
Make sure the suite is up-to-date before reporting an issue. It might've been fixed already.

Try running the build again at a later time.

logs.zip
logs.zip

@dbyoung720
Copy link

same with me .
It seems to be related to zenlib

@nero-0
Copy link

nero-0 commented Jun 20, 2024

It happens to me too.

@jamiesaun85
Copy link
Author

jamiesaun85 commented Jun 20, 2024

so what do we do about it? Ive already deleted both folders and ran again, same thing happens. I guess not include them in the build maybe?

Not sure about you guys but I'm on the recent update for 23H2. The one from last week.

@ls-milkyway
Copy link
Contributor

so what do we do about it? Ive already deleted both folders and ran again, same thing happens. I guess not include them in the build maybe?

Not sure about you guys but I'm on the recent update for 23H2. The one from last week.

nope nothing to do with 23H2...same output on my 22H2.

@dbyoung720
Copy link

image

@jamiesaun85
Copy link
Author

Thanks man. Unfortunately I have absolutely no idea how to interpret any of that. Even less how to implement it. I just wanted to make one of my softwares use hardware acceleration, and somehow ended up here, thinking this build or suite or whatever it is would make it happen.

As far as coding, or communicating with a computer in any way, shit I may as well be Zoolander. I am really really goodlooking after all.

Thanks for the help though. Always appreciated

@L4cache
Copy link
Contributor

L4cache commented Jun 21, 2024

It's the pkgconf can't detect existance of libmediainfo static library. Weird.
error: libmediainfo configuration is not found is what ultimately caused the error


./configure: line 16929: libzen-config: command not found
./configure: line 17028: libmediainfo-config: command not found

These two messages are not important here because these commands are in a test command and a if statement, these are just kind of warnings.

@L4cache
Copy link
Contributor

L4cache commented Jun 21, 2024

Pkgconf can't detect static libmediainfo because it can't find zstd required by libcurl required by libmediainfo.

But zstd also exists! (installed via pacman by the suite)
Maybe just lack of .pc file for it.
It just looking for zstd.pc instead of libzstd.pc

$ pkgconf --keep-system-cflags --static --print-errors --exists libmediainfo
Package zstd was not found in the pkg-config search path.
Perhaps you should add the directory containing `zstd.pc'
to the PKG_CONFIG_PATH environment variable
Package 'zstd', required by 'libcurl', not found

@L4cache
Copy link
Contributor

L4cache commented Jun 21, 2024

Makeshift solution: copy libzstd.pc to zstd.pc.
It's in /mingw64(or clang64)/lib/pkgconfig

@L4cache
Copy link
Contributor

L4cache commented Jun 21, 2024

Maybe we should just disable curl-reader in libmediainfo like this #2707 (comment)

@diegocr
Copy link

diegocr commented Jun 21, 2024

@L4cache worth a try at least, i can tell i just ran the suite, having seen the libzen update, and i got no issues at all getting mediainfo.exe compiled.

@L4cache L4cache mentioned this issue Jun 23, 2024
@LigH-de
Copy link
Contributor

LigH-de commented Jun 24, 2024

Pkgconf can't detect static libmediainfo because it can't find zstd required by libcurl required by libmediainfo.

But zstd also exists! (installed via pacman by the suite) Maybe just lack of .pc file for it. It just looking for zstd.pc instead of libzstd.pc

Your competence is seriously a win for this project! Thank you for contributing!

So this is mainly to be solved in the suite, no need to mention it upstream?

@L4cache
Copy link
Contributor

L4cache commented Jun 24, 2024

Pkgconf can't detect static libmediainfo because it can't find zstd required by libcurl required by libmediainfo.
But zstd also exists! (installed via pacman by the suite) Maybe just lack of .pc file for it. It just looking for zstd.pc instead of libzstd.pc

Your competence is seriously a win for this project! Thank you for contributing!

So this is mainly to be solved in the suite, no need to mention it upstream?

Thank you.
Unfortunately I don't know the exact cause...
It could be pkgconf changed behavior or zstd changed it's .pc file name, and all sorts of possibilities.
But yeah, the workaround can be done just in the suite.

Reporting to upstream is, I don't know, maybe after narrowing the possibilities down?

@L4cache
Copy link
Contributor

L4cache commented Jun 24, 2024

curl/curl@f057de5#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810R1562

curl/curl@f057de5#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR606

Curl recently added Requires.private configuring, they use "libzstd" in cmake but "zstd" in autoconf.

Well, I guess, cmake vs. autoconf again? (not really)

@LigH-de
Copy link
Contributor

LigH-de commented Jun 24, 2024

Well, that was quick. Solved soon™ after MSYS2 updates packages?

@jamiesaun85
Copy link
Author

Soooo, its fixed now? do i just run it again?

@hydra3333
Copy link
Contributor

I deleted the folders for mediainfo, libmediainfo, curl, and re-ran it and ffmpeg built fine.

@L4cache
Copy link
Contributor

L4cache commented Jun 25, 2024

Well, that was quick. Solved soon™ after MSYS2 updates packages?

Curl in MSYS2 packages is not (and will not be) affected, it uses release version and current release is before the addition of Requires.private, and in next release the fix is already there.

@LigH-de
Copy link
Contributor

LigH-de commented Jun 25, 2024

Confirming, compilation of MediaInfo passes.

@1480c1 1480c1 closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants