Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readability trashed after putting length limits. #818

Open
ankitgurua opened this issue Jun 9, 2024 · 1 comment
Open

Readability trashed after putting length limits. #818

ankitgurua opened this issue Jun 9, 2024 · 1 comment

Comments

@ankitgurua
Copy link

Both Whisper and WhisperX have this annoying thing that their default lengths follow nice punctuation rules where subs end at a punctuation and at a time only one sentence appears. Which makes reading much more easier and natural.

Example:

I think he's the love of my life.
Are you sure about it?
Yes, I love him deeper than I've ever loved anyone.

But obviously this also leaves me with sentences that are so big, they take up 4 sentences. And for captions that's just bad.

So i apply the character limiter and max lines and word count parameters in the script. Tho it might does a good job at limiting the length. It kills the readability of the subs. Sentences breaking at random in the middle of the sub. It's not ending it with a punctuation. First letters are not capital as it's not the beginning of a sentence as actual sentence was started in the middle of the previous sub.

Example:

I think he's the love of
my life. Are you sure
about it? Yes, I love him
deeper than I've ever
loved anyone.

(Example is just using 2 speakers but I've the same problem with one speaker narration as well)

What i want is for it to respect the end of sentences AFTER it reduces the length of the sub.

Here's what i want

Example:

I think he's the love of
my life.
Are you sure about it?
Yes, I love him
deeper than I've ever
loved anyone.

@jim60105
Copy link
Contributor

Try --chunk_size
The default value is 30, use a smaller value for captions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants