-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should the driver be shutting down the event loop group? #19
Comments
Hi Tony, Initially that's what I was doing but it was causing some issues, see #11 I'm really not sure what needs to be done; if you have any advice please do share! |
I really don't have any advice, sorry! I was seeing the Jobs table being accessed after I'd initiated shutdown of the app, so something isn't right, but I can't be sure that it's specific to this package, or the parent queues package. In any case, switching to the in-memory test queue provider fixed the issue for me (and is probably more reasonable to use when testing). |
vapor-queues-fluent-driver/Sources/QueuesFluentDriver/FluentQueuesDriver.swift
Lines 51 to 52 in 882718f
I'm seeing some problems in my tests that go away if I disable my app's queues, and they're all related to the Queues package trying to access PostgreSQL after they are supposed to (during/after application shutdown).
Should the driver be shutting down the event loop group that it owns during the lifecycle method here?
The text was updated successfully, but these errors were encountered: