code comments addressed

m00g3n · Jul 26, 2024 · e2f435e · e2f435e
1 parent 18c6202
commit e2f435e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/api/v1/runtime_types.go b/api/v1/runtime_types.go
@@ -61,9 +61,10 @@ const (
 type RuntimeConditionType string
 
 const (
-	ConditionTypeRuntimeProvisioned     RuntimeConditionType = "Provisioned"
-	ConditionTypeRuntimeKubeconfigReady RuntimeConditionType = "KubeconfigReady"
-	ConditionTypeRuntimeConfigured      RuntimeConditionType = "Configured"
+	ConditionTypeRuntimeProvisioned       RuntimeConditionType = "Provisioned"
+	ConditionTypeRuntimeProvisionedDryRun RuntimeConditionType = "ProvisionedDryRun"
+	ConditionTypeRuntimeKubeconfigReady   RuntimeConditionType = "KubeconfigReady"
+	ConditionTypeRuntimeConfigured        RuntimeConditionType = "Configured"
 )
 
 type RuntimeConditionReason string

diff --git a/docs/README.md b/docs/README.md
@@ -16,14 +16,18 @@ You can configure the Infrastructure Manager deployment with the following argum
 3. `minimal-rotation-time` - the ratio determines what is the minimal time that needs to pass to rotate the certificate
 4. `kubeconfig-expiration-time` - maximum time after which kubeconfig is rotated. The rotation happens between (`minimal-rotation-time` * `kubeconfig-expiration-time`) and `kubeconfig-expiration-time`.
 4. `gardener-request-timeout` - specifies the timeout for requests to Gardener. Default value is `60s`.
-5. `runtime-reconciler-enabled` - feature flag responsible for enabling the runtime reconciler. Default value is `false`.
+5. `runtime-reconciler-enabled` - feature flag responsible for enabling the runtime reconciler. Default value is `true`.
 6. `shoot-spec-dump-enabled` - feature flag responsible for enabling the shoot spec dump. Default value is `false`.
 
 
 See [manager_gardener_secret_patch.yaml](../config/default/manager_gardener_secret_patch.yaml) for default values.
 
 ## Troubleshooting
 
+1. Switching between the `provisioner` and the `kim`.
+
+The `kyma-project.io/controlled-by-provisioner` label provides fine-grained control over `Runtime` CR. Only if the label value is set to `false`, resource is considered managed and will be controlled by the `kyma-application-manager`.
+
 > TBD: List potential issues and provide tips on how to avoid or solve them. To structure the content, use the following sections:
 >
 > - **Symptom**

diff --git a/internal/controller/runtime/fsm/runtime_fsm_create_shoot_dry_run.go b/internal/controller/runtime/fsm/runtime_fsm_create_shoot_dry_run.go
@@ -23,7 +23,7 @@ func sFnCreateShootDryRun(_ context.Context, m *fsm, s *systemState) (stateFn, *
 
 	s.shoot = &newShoot
 	s.instance.UpdateStateReady(
-		imv1.ConditionTypeRuntimeProvisioned,
+		imv1.ConditionTypeRuntimeProvisionedDryRun,
 		imv1.ConditionReasonConfigurationCompleted,
 		"Runtime processing completed successfully [dry-run]")