Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movie OMDB - Pagination - missing results #144

Open
7 tasks done
tbonnard opened this issue May 20, 2024 · 1 comment
Open
7 tasks done

Movie OMDB - Pagination - missing results #144

tbonnard opened this issue May 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@tbonnard
Copy link

tbonnard commented May 20, 2024

  • The Plugin is up to date
  • Obsidian is up to date

Describe the bug
it seems that pagination is not taking into account for the OMDB API. Example, when you search on "Seven", you only get a few results in the api but if you add the pagination, you get the next results.
Example: https://www.omdbapi.com/?s=Seven&apikey=[your_Api_Key]&page=4

To Reproduce
Search for Seven: you will only see a few results
Go on the url with your API Key and add &page=2 ... you will see the other results (for sure, depending on the search, there might be a lot of pages).

Expected behavior
Either a scroll or a pagination could be helpful because right now, some movies are missing.

Screenshots

Occurs on
Tested on Windows. No idea for the others but I guess the behaviour is the same.

  • Windows
  • macOS
  • Linux
  • Android
  • iOS

Plugin version
0.6.0

Additional context
Thank you for your help!

@tbonnard tbonnard added the bug Something isn't working label May 20, 2024
@mProjectsCode
Copy link
Owner

The API does not offer a way to increase page size. Adding pagination to the search results in the plugin sounds like a lot of work. So this is not something I am going to tackle anytime soon, except if someone comes up with a good idea how to tackle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants