Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liquid woes #655

Open
3 of 4 tasks
wgreenberg opened this issue Apr 7, 2024 · 2 comments
Open
3 of 4 tasks

Liquid woes #655

wgreenberg opened this issue Apr 7, 2024 · 2 comments
Milestone
World of Warcraft

Comments

@wgreenberg
Copy link
Collaborator

wgreenberg commented Apr 7, 2024 •
edited by magcius
Loading

Liquids still have a couple things missing:

  • The colors seem wrong, for example the Stormwind canals shouldn't be green
  • Liquid type seems wrong in many places, for example water in Ironforge's main forge area, and water instead of slime in Felwood
  • Haven't implemented water flowing
  • Lava outside of Blackrock Mountain isn't tiling correctly:
    image
@wgreenberg wgreenberg added this to the World of Warcraft milestone Apr 7, 2024
magcius added a commit that referenced this issue Apr 15, 2024
@magcius
World of Warcraft: Fix ADT liquid texcoords
0bd6165 
In order to get texcoord 0...1 we need to divide by size - 1.

Addresses part of #655.
@magcius
Copy link
Owner

magcius commented Apr 15, 2024

0bd6165 fixes ADT liquid texture coordinates

@wgreenberg
Copy link
Collaborator Author

#669 fixes all but water flowing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
World of Warcraft
Development

No branches or pull requests
2 participants
@magcius @wgreenberg