-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close button not working in a mobile device on product image zoom popup. #34886
Comments
Hi @paresh6002. Thank you for your report.
Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
For more details, review the Magento Contributor Assistant documentation. Add a comment to assign the issue: To learn more about issue processing workflow, refer to the Code Contributions.
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @engcom-Echo. Thank you for working on this issue.
|
Hi @paresh6002, Thank you for reporting the issue. However, I am not able to reproduce the same. I have tried on multiple fresh 2.4-develop instances but the zoomed up product image on detail page is getting closed properly. The close button action is not getting affected by the console error and I think that console error is already being addressed by our team somewhere. Some screenshots attached of my trials. So, based on it please update below queries:
Thanks |
Hi @engcom-Echo Thank You |
Hi @paresh6002, Thank you for providing the video. Since you are checking on your website, it could be happening due to some other error which you may have been getting after deployment. You can check logs and see if you find anything. For confirmation, you can also check on fresh Magento installation or Magento 2.4-develop instance. I have checked again, even on Magento 2.4.3-p1 but this functionality seems to be working fine. Please check attached video for your ref. Screen.Recording.movCan you please check on fresh installation and let me know if you still face this issue and if yes, please update description with some more info ? Thanks |
Hi @engcom-Echo Argus-All-Weather-Tank.mp4 |
Hi @paresh6002, Thank you for providing the video. I understood when the issue is happening. Verified the issue and is reproducible on Magento 2.4-develop. As per analysis, there are 3 issues happening when you zoom-in and zoom-out any product image:
All issues are reproduced exactly shown in the video by Reporter. Therefore confirming the issue. Thanks |
✅ Jira issue https://jira.corp.magento.com/browse/AC-2075 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Echo. Thank you for verifying the issue. |
@magento I am working on this |
Thanks! I had the same issue on Magento 2.4.3-p2, your fix saved me fixing this issue for the client! I approve :) This works. |
@Melnychuk-Alexandr was this fixed? |
Hi @paresh6002, Thanks for your reporting and collaboration. We have verified the issue in Latest 2.4-develop instance and the issue is still reproducible.kindly refer the screenshots. Hence Confirming the issue. Thanks. |
❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-2075 |
Preconditions (*)
Steps to reproduce (*)
Description (*)
I found issue artpolikarpov/fotorama#529 on fotorama git repo. so It is related to each other.
all events get passive listener to by using this code.
el.addEventListener ? el.addEventListener(e, fn, {passive: true}) : el.attachEvent('on' + e, fn);
File path: lib/web/fotorama/fotorama.js
Line No: 1143
I found this pull request artpolikarpov/fotorama#574
Expected result (*)
Actual result (*)
As per analysis, there are 3 issues happening when you zoom-in and zoom-out any product image:
Example
Argus-All-Weather-Tank.mp4
Related issue: #33855
Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.
The text was updated successfully, but these errors were encountered: