Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button not working in a mobile device on product image zoom popup. #34886

Open
1 of 5 tasks
paresh6002 opened this issue Dec 27, 2021 · 14 comments · May be fixed by #35017
Open
1 of 5 tasks

Close button not working in a mobile device on product image zoom popup. #34886

paresh6002 opened this issue Dec 27, 2021 · 14 comments · May be fixed by #35017
Assignees
Labels
Area: UI Framework Component: Developer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@paresh6002
Copy link

paresh6002 commented Dec 27, 2021

Preconditions (*)

  1. Magento 2.4.3-p1

Steps to reproduce (*)

  1. Open product page on a mobile device
  2. Scroll product page on mobile
  3. Click on a product image then zoom popup open
  4. Then try to close the popup by clicking the close button
  5. Popup can't be close.

Description (*)

I found issue artpolikarpov/fotorama#529 on fotorama git repo. so It is related to each other.
all events get passive listener to by using this code.

el.addEventListener ? el.addEventListener(e, fn, {passive: true}) : el.attachEvent('on' + e, fn);

File path: lib/web/fotorama/fotorama.js
Line No: 1143

I found this pull request artpolikarpov/fotorama#574

Expected result (*)

  1. Image zoom popup should be closed by clicking on the close button

Screenshot-3-zoom

Actual result (*)

As per analysis, there are 3 issues happening when you zoom-in and zoom-out any product image:

  1. If you click on the product and close it again, mini cart will open itself like below:

Screenshot 2022-01-07 at 12 34 24 PM

  1. If you again click on the product and close it again, search bar will open itself like below:

Screenshot 2022-01-07 at 12 38 00 PM

  1. If you go a little bit down from the product image and then click on product to zoom-in and then try to close it, the product will be not be able to close and user needs to be refresh the page.

Screenshot-from-2021-12-27-12-44-45-png-1920×1080-

Example

Argus-All-Weather-Tank.mp4

Related issue: #33855

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Dec 27, 2021

Hi @paresh6002. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Dec 27, 2021

Hi @engcom-Echo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Echo
Copy link
Contributor

Hi @paresh6002,

Thank you for reporting the issue.

However, I am not able to reproduce the same. I have tried on multiple fresh 2.4-develop instances but the zoomed up product image on detail page is getting closed properly. The close button action is not getting affected by the console error and I think that console error is already being addressed by our team somewhere. Some screenshots attached of my trials.

Screenshot 2021-12-28 at 1 12 46 PM

Screenshot 2021-12-28 at 1 11 42 PM

So, based on it please update below queries:

  1. Can you please check if this issue is reproducible on Magento 2.4-develop instance ?
  2. Let me know if you did anything differently then specified in 'Steps to reproduce', maybe this behaviour is happening after some action ?

Thanks

@engcom-Echo engcom-Echo added the Issue: needs update Additional information is require, waiting for response label Dec 28, 2021
@engcom-Echo engcom-Echo added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Dec 28, 2021
@paresh6002
Copy link
Author

paresh6002 commented Dec 28, 2021

Hi @engcom-Echo
I have added a video for this issue. so you can try to reproduce this issue by scrolling as shown in the video. the issue is in the mobile devices.

Thank You

@engcom-Echo
Copy link
Contributor

Hi @paresh6002,

Thank you for providing the video.

Since you are checking on your website, it could be happening due to some other error which you may have been getting after deployment. You can check logs and see if you find anything.

For confirmation, you can also check on fresh Magento installation or Magento 2.4-develop instance. I have checked again, even on Magento 2.4.3-p1 but this functionality seems to be working fine. Please check attached video for your ref.

Screen.Recording.mov

Can you please check on fresh installation and let me know if you still face this issue and if yes, please update description with some more info ?

Thanks

@paresh6002
Copy link
Author

Hi @engcom-Echo
I have reproduced the issue on fresh Magento installation for Magento 2.4-develop instance. I have attached a new video here. so you can follow the same step as the attached video.
And I can see the issue in your video. the search bar/mini-cart will get open when you close the popup. That should not open while closing the image popup.

Argus-All-Weather-Tank.mp4

@engcom-Echo
Copy link
Contributor

Hi @paresh6002,

Thank you for providing the video.

I understood when the issue is happening. Verified the issue and is reproducible on Magento 2.4-develop.

As per analysis, there are 3 issues happening when you zoom-in and zoom-out any product image:

  1. If you click on the product and close it again, mini cart will open itself like below:

Screenshot 2022-01-07 at 12 34 24 PM

  1. If you again click on the product and close it again, search bar will open itself like below:

Screenshot 2022-01-07 at 12 38 00 PM

  1. If you go a little bit down from the product image and then click on product to zoom-in and then try to close it, the product will be not be able to close and user needs to be refresh the page.

All issues are reproduced exactly shown in the video by Reporter. Therefore confirming the issue.

Thanks

@engcom-Echo engcom-Echo added Area: UI Framework Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch labels Jan 7, 2022
@m2-community-project m2-community-project bot removed the Issue: needs update Additional information is require, waiting for response label Jan 7, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-2075 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Jan 7, 2022

✅ Confirmed by @engcom-Echo. Thank you for verifying the issue.
Issue Available: @engcom-Echo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 11, 2022
@Melnychuk-Alexandr
Copy link
Contributor

@magento I am working on this

@Gorebane
Copy link

Thanks! I had the same issue on Magento 2.4.3-p2, your fix saved me fixing this issue for the client! I approve :) This works.

@Davi-Lobo
Copy link

@Melnychuk-Alexandr was this fixed?

@engcom-Bravo
Copy link
Contributor

Hi @paresh6002,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is still reproducible.kindly refer the screenshots.

Screenshot 2024-10-16 at 11 43 08 Screenshot 2024-10-16 at 11 43 14

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Developer and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Oct 16, 2024
@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-2075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: UI Framework Component: Developer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Pull Request In Progress
Development

Successfully merging a pull request may close this issue.

8 participants