Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkg-config for wld #5

Open
MichaelMackus opened this issue Mar 13, 2018 · 5 comments
Open

Use pkg-config for wld #5

MichaelMackus opened this issue Mar 13, 2018 · 5 comments

Comments

@MichaelMackus
Copy link
Contributor

Is there a specific reason to include the wld sources in the git repository? I guess it means there are less dependencies to download, but I think we'd be better off with pkg-config (or at least prefer the users' library rather than the one included). This way we can update wld separately, plus lots of people might already have wld compiled (velox users).

@MichaelMackus
Copy link
Contributor Author

NOTE: for some reason, this makes the repo unable to compile on Gentoo until I added the WLD links/sources AND the pixman sources (before WLD in the cflags). I think it has to due with the Makefile unable to look up the pixman sources at that point (was getting a lot of undefined references to pixman typedefs).

@majestrate
Copy link
Owner

I could add WLD as a git submodule maybe.

@MichaelMackus
Copy link
Contributor Author

I'm not too particular on how it gets included (but a submodule might be better). I was more referring to the fact I'd just rather use my system WLD over the included WLD (via pkg-config) if it is available. Do you foresee any issues with that?

@majestrate
Copy link
Owner

Do you foresee any issues with that?

possibly, I made some changes to WLD a while ago (forgot what they were) so I bundled WLD because the library seemed dead.

@MichaelMackus
Copy link
Contributor Author

MichaelMackus commented Mar 14, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants