Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingawei/undo delete wrapped #3194

Merged
merged 14 commits into from
Dec 6, 2024
Merged

Ingawei/undo delete wrapped #3194

merged 14 commits into from
Dec 6, 2024

Conversation

ingawei
Copy link
Collaborator

@ingawei ingawei commented Dec 6, 2024

Added wrapped back
image
Would appreciate a sanity check to see if data I pulled is actually in line with reality lol, please see comments

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 9:30pm
prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 9:30pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 9:30pm

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is supposed to get the contract where you made the most profit, and the contract where you made the least profit in 2024. Filtered by contracts that resolved in 2024

Copy link
Collaborator

@IanPhilips IanPhilips Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I don't think you need to selecet has-yes-shares and no shares, nor answer id

@ingawei ingawei requested review from IanPhilips and sipec December 6, 2024 19:32
Copy link
Member

@sipec sipec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane to me

Copy link
Collaborator

@IanPhilips IanPhilips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Excited to see mine

@ingawei ingawei merged commit 6cdb616 into main Dec 6, 2024
6 checks passed
@ingawei ingawei deleted the ingawei/undo-delete-wrapped branch December 6, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants