Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move requests_toolbelt to requirements.txt #132

Open
manu-chroma opened this issue Oct 31, 2018 · 3 comments
Open

Move requests_toolbelt to requirements.txt #132

manu-chroma opened this issue Oct 31, 2018 · 3 comments

Comments

@manu-chroma
Copy link
Owner

Since it is not a test requirement and is actually used in the username_api source:

https://github.com/manu-chroma/username-availability-checker/blob/master/username_api.py#L8

@seeeturtle
Copy link
Collaborator

@manu-chroma, the reason i did like that is because the result of it is actually used in test, not the server. you can know that from travis file.

@manu-chroma
Copy link
Owner Author

but you cannot run the server without installing test requirements. That's why it should be moved into main requirements

@seeeturtle
Copy link
Collaborator

Then I think it should be only used when testing, not putting in requirements.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants