Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relationships links ignoring GetCustomLinks #354

Open
verkestk opened this issue Jul 9, 2024 · 1 comment
Open

relationships links ignoring GetCustomLinks #354

verkestk opened this issue Jul 9, 2024 · 1 comment

Comments

@verkestk
Copy link

verkestk commented Jul 9, 2024

Is there a way to exclude or customize the links object from a relationship? I've been trying to do figure this out without any luck.

Some context:
I have some resource types I want to include links for, and other resource types I do not. So I'm using jsonapi.MarshalWithURLs and then using a GetCustomLinks method to return an empty map for the resources that should not have links.

This is working for the included part of the marshaled payload. However, the links are still included in the relationships part of the payload. What's returned by GetCustomLinks does not appear to impact the link values in the relationships object.

Which is resulting in the following 2 problems:

  • links present for some related resources where I don't want them
  • links incorrect for other related resources where I've customized them
@sharpner
Copy link
Member

sharpner commented Jul 9, 2024

As soon as the interface is implemented, the links object will be marshalled - but it doesn't have to be that way - feel free to open a PR to change that behaviour!

if customLinks, ok := element.(MarshalCustomLinks); ok {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants