Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding "show" props #36

Open
conorhastings opened this issue Aug 14, 2015 · 3 comments
Open

Adding "show" props #36

conorhastings opened this issue Aug 14, 2015 · 3 comments
Labels
enhancement groomed help wanted jira-sync-complete

Comments

@conorhastings
Copy link
Contributor

Wondering if there would be support for adding "show props" here. For example application that does not support alpha transparency can pass in prop to not show the alpha picker, etc... Thanks!
@tmcw
Copy link
Contributor

tmcw commented Aug 14, 2015

If we added this it seems like we'd need to add a validation step to make sure the color picker is never initialized with an alpha < 1.

@conorhastings
Copy link
Contributor Author

Yeah agreed that would have to happen and makes this is a little trickier, but only if the user passes in the option to not show alpha. I'd be happy to work on something/submit a PR and see what you guys think.

@samanpwbb
Copy link
Contributor

Would love to see a little more visibility control over UI elements in the picker. Sometimes all you want is a color field.

@tristen tristen mentioned this issue Apr 16, 2021
Closed
tristen added a commit that referenced this issue Apr 17, 2021
@tristen
Add alpha option
7dd4e43 
- Ref #36
@tristen tristen mentioned this issue Apr 26, 2021
Merged
tristen added a commit that referenced this issue Apr 29, 2021
@tristen
Update react-colorpickr (#149)
cb9766a 
* Use functional components

* Upgrade packages and get running

* Fixes to coordinate reads

* Maintin an internal value to drop leading zero

- Closes #111

* Drop leading hash if provided to HEX input

- Closes #130

* Add accessibility to reset button

- Ref #145

* Add alpha option

- Ref #36

* Tests

* Format with prettier :/

* Tests

* Snapshot xy component

* Node 10

* Fix tests

* Bump Node version in Travis to 14 and use version of React that introduces shared hooks

* Feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement groomed help wanted jira-sync-complete
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tmcw @tristen @samanpwbb @conorhastings @miafan23 @aswamina