Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems loading benchmarks_generated.js of v4.7.1 #4762

Open
birkskyum opened this issue Sep 25, 2024 · 3 comments
Open

Problems loading benchmarks_generated.js of v4.7.1 #4762

birkskyum opened this issue Sep 25, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers PR is more than welcomed Extra attention is needed

Comments

@birkskyum
Copy link
Member

birkskyum commented Sep 25, 2024

When running the bench, it only shows 4.7.1 and main and not the current branch. My hypothesis is that it fails to load/register the latest tag 4.7.1, then loads main (displayed as 4.7.1) and the local branch (displayed as main).

Screenshot 2024-09-25 at 12 18 16

Workaround

Changing this line:

window.versionsDisplayName = [responseJson['tag_name'], 'main'];

To use 4.7.0 instead:
window.versionsDisplayName = ['v4.7.0', 'main'];

Resolves the problem:
Screenshot 2024-09-25 at 12 19 30

@birkskyum birkskyum changed the title Problems running bench, since 4.7.1 was released Problems loading benchmarks_generated.js of v4.7.1 Sep 25, 2024
@HarelM
Copy link
Collaborator

HarelM commented Sep 25, 2024

4.7.1 was recently uploaded to gh-pages, one should be able to try and load the script and see what's wrong.
I guess we should have better automation to avoid these kind of issues...

@HarelM HarelM added bug Something isn't working good first issue Good for newcomers PR is more than welcomed Extra attention is needed labels Sep 25, 2024
@HarelM
Copy link
Collaborator

HarelM commented Sep 29, 2024

It is possible that this is because main and 4.7.1 have the same commit and so the code the runs the benchmarks gets confused and only shows main and the current branch with the wrong titles?
The following seems to work for me:

$1> npm run start-bench
$2> npm run benchmark -- --compare v4.7.0 --compare v4.6.0 --compare v4.7.1

@HarelM
Copy link
Collaborator

HarelM commented Sep 29, 2024

I think the following code solves this issue and issues in general where you add version with the same commit, I'm just not sure it's worth adding to the benchmark code, it is already too complicated... :-(
This basically checks (badly) that when loading a new script more benchmarks versions are added, and if this is not the case the current version display name is removed from the list.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers PR is more than welcomed Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants