-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems loading benchmarks_generated.js of v4.7.1 #4762
Labels
bug
Something isn't working
good first issue
Good for newcomers
PR is more than welcomed
Extra attention is needed
Comments
birkskyum
changed the title
Problems running bench, since 4.7.1 was released
Problems loading benchmarks_generated.js of v4.7.1
Sep 25, 2024
4.7.1 was recently uploaded to gh-pages, one should be able to try and load the script and see what's wrong. |
HarelM
added
bug
Something isn't working
good first issue
Good for newcomers
PR is more than welcomed
Extra attention is needed
labels
Sep 25, 2024
It is possible that this is because
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
good first issue
Good for newcomers
PR is more than welcomed
Extra attention is needed
When running the bench, it only shows
4.7.1
andmain
and not the current branch. My hypothesis is that it fails to load/register the latest tag4.7.1
, then loadsmain
(displayed as4.7.1
) and the local branch (displayed asmain
).Workaround
Changing this line:
maplibre-gl-js/test/bench/versions/index.html
Line 24 in 3160299
To use 4.7.0 instead:
window.versionsDisplayName = ['v4.7.0', 'main'];
Resolves the problem:
The text was updated successfully, but these errors were encountered: