-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Massive refactor in python #13
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I like the schema for the YAML files that describe the analysis to be done (e.g. CORE_vs_JRA.yml) but the python code that parses it (specifically
analysis_class.py
,data_source_classes.py
, andgeneric_classes.py
) all have remnants of previous iterations of the YAML file scattered throughout. I think a top-down rewrite should focus on the following:better class names (already a ticket via Better names for classes in code #2 and I'll comment on that issue with some thoughts)
AnalysisCategory._open_datasets()
should be far slimmer. No need for code likewhen we can manage all of that in an
Operators
class (see howxcollection
handles operators for motivation)The text was updated successfully, but these errors were encountered: