Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorations drawn by external decorator are smaller that the window reserved for it. #2

Open
mark-herbert42 opened this issue Mar 10, 2024 · 4 comments

Comments

@mark-herbert42
Copy link

2024-03-10_10:59:36

I use windows shadow plugin to draw shadows, and with standard decoration or firedecor it gives exact match, but in this decorator the shadows are between the end of decorations and start of shadow.

@mark-herbert42
Copy link
Author

Found the reason for it - 4 pix hardcoded in decorator process as delta and is getting always added to the theme settings.

@marcof-nikogo
Copy link
Owner

Hi,
yeah, I will add a config parameter to set the delta border.
Unfortunately it is needed, since if the metacity theme has a 0px border the window cannot be resized.

@lukefromdc
Copy link
Contributor

I just found that this change didn't change nonworking shadows here but with both Menta and my UbutuStudio_Legacy theme
https://github.com/lukefromdc/gtk-theme-ubuntustudio-legacy
greatly reduced the prominance of the nontransparent underlying window behind the decorations,
#6
so that it is now visible only at the rounded corners. Interestingly, I still get the ability to resize from just outside the visible border in these two themes.

@lukefromdc
Copy link
Contributor

Note that shadows are not working here with wayfire 0.8.0 on Debian Unstable no matter what the decorator.

Also on fullscreen or tiled windows, the window contents are drawn several px smaller than the inside of the decorations, and the titlebar thus appears to be slightly too long and the desktop or other background beneath is visible through that gap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants