[Request] Turn into an npm module + add CLI tool

[eadmaster]

followup

I'm mosty interested in this for easier cmdline use:

$ npm install -g RomPatcher  # a script `RomPatcher` is added in $PATH
$ RomPatcher patch "my_rom.bin" "my_patch.ips"

[romh-acking]

+1

I'm interested in this because it makes it easier to include this package in codebases.

[marcrobledo]

Haven't tried it yet, but I've created my very first npm module: rom-patcher

Can anyone try it?

npm install -g rom-patcher
RomPatcher --help

[romh-acking]

I get this error when trying to import into my React project.

Failed to compile.

Module not found: Error: Can't resolve 'path' in '/home/xxxx/ui/node_modules/rom-patcher/rom-patcher-js/modules'
BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "path": require.resolve("path-browserify") }'
        - install 'path-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "path": false }

ERROR in ./node_modules/rom-patcher/rom-patcher-js/modules/BinFile.js 308:13-28
Module not found: Error: Can't resolve 'path' in '/home/xxxx/ui/node_modules/rom-patcher/rom-patcher-js/modules'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "path": require.resolve("path-browserify") }'
        - install 'path-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "path": false }

ERROR in ./node_modules/rom-patcher/rom-patcher-js/modules/BinFile.js 309:11-24
Module not found: Error: Can't resolve 'fs' in '/home/xxxx/ui/node_modules/rom-patcher/rom-patcher-js/modules'

ERROR in ./node_modules/rom-patcher/node_modules/commander/lib/command.js 2:21-45
Module not found: Error: Can't resolve 'child_process' in '/home/xxxx/ui/node_modules/rom-patcher/node_modules/commander/lib'

ERROR in ./node_modules/rom-patcher/node_modules/commander/lib/command.js 3:13-28
Module not found: Error: Can't resolve 'path' in '/home/xxxx/ui/node_modules/rom-patcher/node_modules/commander/lib'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "path": require.resolve("path-browserify") }'
        - install 'path-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "path": false }

ERROR in ./node_modules/rom-patcher/node_modules/commander/lib/command.js 4:11-24
Module not found: Error: Can't resolve 'fs' in '/home/xxxx/ui/node_modules/rom-patcher/node_modules/commander/lib'

[marcrobledo]

I get this error when trying to import into my React project.

Failed to compile.

Module not found: Error: Can't resolve 'path' in '/home/xxxx/ui/node_modules/rom-patcher/rom-patcher-js/modules'
BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "path": require.resolve("path-browserify") }'
        - install 'path-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "path": false }

ERROR in ./node_modules/rom-patcher/rom-patcher-js/modules/BinFile.js 308:13-28
Module not found: Error: Can't resolve 'path' in '/home/xxxx/ui/node_modules/rom-patcher/rom-patcher-js/modules'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "path": require.resolve("path-browserify") }'
        - install 'path-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "path": false }

ERROR in ./node_modules/rom-patcher/rom-patcher-js/modules/BinFile.js 309:11-24
Module not found: Error: Can't resolve 'fs' in '/home/xxxx/ui/node_modules/rom-patcher/rom-patcher-js/modules'

ERROR in ./node_modules/rom-patcher/node_modules/commander/lib/command.js 2:21-45
Module not found: Error: Can't resolve 'child_process' in '/home/xxxx/ui/node_modules/rom-patcher/node_modules/commander/lib'

ERROR in ./node_modules/rom-patcher/node_modules/commander/lib/command.js 3:13-28
Module not found: Error: Can't resolve 'path' in '/home/xxxx/ui/node_modules/rom-patcher/node_modules/commander/lib'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "path": require.resolve("path-browserify") }'
        - install 'path-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "path": false }

ERROR in ./node_modules/rom-patcher/node_modules/commander/lib/command.js 4:11-24
Module not found: Error: Can't resolve 'fs' in '/home/xxxx/ui/node_modules/rom-patcher/node_modules/commander/lib'

I've fixed a path that was wrong in package.json. Can you update your Rom Patcher JS npm package and try again?

[romh-acking]

This is the error I get. I can confirm in node modules I have version v20241102:

ERROR in ./node_modules/rom-patcher/rom-patcher-js/modules/BinFile.js 308:13-28
Module not found: Error: Can't resolve 'path' in '/home/xxx/ui/node_modules/rom-patcher/rom-patcher-js/modules'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "path": require.resolve("path-browserify") }'
        - install 'path-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "path": false }

ERROR in ./node_modules/rom-patcher/rom-patcher-js/modules/BinFile.js 309:11-24
Module not found: Error: Can't resolve 'fs' in '/home/xxx/ui/node_modules/rom-patcher/rom-patcher-js/modules'

ERROR in ./node_modules/rom-patcher/node_modules/commander/lib/command.js 2:21-45
Module not found: Error: Can't resolve 'child_process' in '/home/xxx/ui/node_modules/rom-patcher/node_modules/commander/lib'

ERROR in ./node_modules/rom-patcher/node_modules/commander/lib/command.js 3:13-28
Module not found: Error: Can't resolve 'path' in '/home/xxx/ui/node_modules/rom-patcher/node_modules/commander/lib'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "path": require.resolve("path-browserify") }'
        - install 'path-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "path": false }

ERROR in ./node_modules/rom-patcher/node_modules/commander/lib/command.js 4:11-24
Module not found: Error: Can't resolve 'fs' in '/home/xxx/ui/node_modules/rom-patcher/node_modules/commander/lib'

ERROR in ./node_modules/rom-patcher/node_modules/commander/lib/command.js 5:16-34
Module not found: Error: Can't resolve 'process' in '/home/xxx/ui/node_modules/rom-patcher/node_modules/commander/lib'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "process": require.resolve("process/browser") }'
        - install 'process'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "process": false }

This is my React import:

import RomPatcher from "rom-patcher";