-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expiry not set in cookieStorage.js #325
Comments
this library save expires with another cookie, I don't know why this way instead of cookie expires attribute, also another drawback, if you save a string value, it will be serialized by JSON.stringify() , which means double quotes will be part of you value. you need to strip it out if cookie being passed to your server. for example, a token,
|
#328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There seems to be an issue with cookieStorage.js which doesn't seem to accept the expiry set for cookies. The expiry is hardcoded ->
store.js/storages/cookieStorage.js
Line 43 in b8e22fe
Shouldn't the user be allowed to set it or fallback to default?
The text was updated successfully, but these errors were encountered: