Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Execute methods out of PostcodesIOClient #13

Open
markembling opened this issue Apr 15, 2019 · 0 comments
Open

Move Execute methods out of PostcodesIOClient #13

markembling opened this issue Apr 15, 2019 · 0 comments
Milestone
v1.0.0

Comments

@markembling
Copy link
Owner

Move these out so they can be swapped out for more testing without hitting a live API.

Also will prevent duplication for #11.
@markembling markembling mentioned this issue Apr 17, 2019
Closed
markembling added a commit that referenced this issue Apr 20, 2019
@markembling
Move execute methods out of PostcodesIOClient
e4bd829 
Execution has been moved into a class specifically responsible for this.
Fixes #13.
@markembling markembling added this to the v1.0.0 milestone May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@markembling