Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support and/or log the new rate limit APIs #76

Open
hpernu opened this issue Aug 15, 2024 · 0 comments
Open

Support and/or log the new rate limit APIs #76

hpernu opened this issue Aug 15, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@hpernu
Copy link
Collaborator

hpernu commented Aug 15, 2024

I understand this may require changes in the Nordigen library first.

Now that Gocardless is putting rate limits in place we should modify the code to take in account that rate limit errors are a common occurence. Furthermore, on every request it would be immensely useful if the remaining API calls and the next reset time would be shown on the logs (at least in debugging mode).

As I just received e-mail from Gocardless about these APIs, I doubt they are actually yet implemented on Nordigen library. But once they are, we should properly output errors if rate limit has been exceeded with (hopefully) a time when they'll be reset. This would be the first step.

@martinohansen martinohansen added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 2, 2024
martinohansen added a commit that referenced this issue Sep 16, 2024
Crude way to fail gracefully when the rate limit is exceeded.

Ref: #76

commit-id:25e9d0c8
martinohansen added a commit that referenced this issue Sep 16, 2024
Crude way to fail gracefully when the rate limit is exceeded.

Ref: #76

commit-id:25e9d0c8
martinohansen added a commit that referenced this issue Sep 16, 2024
Crude way to fail gracefully when the rate limit is exceeded.

Ref: #76

commit-id:25e9d0c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants