Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeclared underscore dependency in build/prebundle.js #1

Open
n-j-m opened this issue Jan 21, 2015 · 1 comment
Open

Undeclared underscore dependency in build/prebundle.js #1

n-j-m opened this issue Jan 21, 2015 · 1 comment

Comments

@n-j-m
Copy link

n-j-m commented Jan 21, 2015

There's a dependency on underscore in the generated prebundle.js file.

var _ = require('underscore');

It's a little confusing since underscore isn't listed as a dependency in the package.json file of the generated app. This seems to work, currently, because underscore is a peer dependency of react-page-objects. This causes npm to put underscore in the top-level of the node_modules folder.

Maybe update the script to use lodash instead, since it's already a dependency of the generated app. It would future-proof the generated app if underscore ever is removed as a peer dependency.

@jhollingworth
Copy link
Contributor

this has been fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants