Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F.tryAll() #161

Open
nicolas-zozol opened this issue Nov 10, 2020 · 4 comments
Open

F.tryAll() #161

nicolas-zozol opened this issue Nov 10, 2020 · 4 comments
Assignees

Comments

@nicolas-zozol
Copy link
Collaborator

Instead of F.try(F.try(x).or(y)).or(z) or F.try(x).or(F.try(y)).orz(), we could use F.tryAll(x, y, z)

@nicolas-zozol nicolas-zozol self-assigned this Nov 10, 2020
nicolas-zozol added a commit that referenced this issue Nov 10, 2020
@d-plaindoux
Copy link
Member

The parser try(x.or(y)).or(z) is enough. In your proposition, You mix Try and Or in the same construction and I think this is error-prone.

@d-plaindoux
Copy link
Member

No pull request?

@nicolas-zozol
Copy link
Collaborator Author

nicolas-zozol commented Nov 12, 2020

Oups 😄 Let me revert that.
I will make the tryAll snippet in the documentation so that people can use it if they like. Personally, I prefer it for the kind of job I do. But you are right, it's way better to keep this low-level, well separated.

@nicolas-zozol
Copy link
Collaborator Author

As there is very few development, I tend to push on dev and make the PR on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants