Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Refactorings in WindowManager and FeatureSpecsService #271

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Minor Refactorings in WindowManager and FeatureSpecsService #271

merged 3 commits into from
Nov 2, 2023

Conversation

maarzt
Copy link
Contributor

@maarzt maarzt commented Nov 2, 2023 •
edited
Loading

The PR fixes some minor problems in the code:

  1. Remove unused code
  2. Better solution to the dependency problem between FeatureSpecService and PluginServive
  3. Fix type casts that do not compile with Java 11

@maarzt
Make the FeatureSpecService's dependency on the PluginService explicit
c5a86ea 
This makes the previous workaround "setting the priority to EXTREMLY_LOW"
obsolete.
@maarzt
Remove unused contants from the WindowManager
3a494f5
@maarzt
Fix type cast in WindowManager
1d96327 
This commit simplifies the type conversion and satisfies the compiler.
(The previous code didn't compile on my machine with openJDK 11)
@tinevez tinevez merged commit d1122b1 into dev Nov 2, 2023
1 check passed
@tinevez tinevez deleted the clean-up branch November 2, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinevez tinevez tinevez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maarzt @tinevez