Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework import / export menus #332

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Rework import / export menus #332

merged 1 commit into from
Oct 9, 2024

Conversation

tinevez
Copy link
Contributor

@tinevez tinevez commented Oct 9, 2024

There are now two submenus in the File main menu that are made for plugins that import or export data in the current mastodon session.
With this PR, the Plugins menu of a 'naked' mastodon application (with no other artifact present) is empty and not shown.

Screenshot 2024-10-09 at 15 47 38

@tinevez tinevez changed the base branch from master to dev October 9, 2024 13:49
@stefanhahmann stefanhahmann self-requested a review October 9, 2024 13:51
Copy link
Collaborator

@stefanhahmann stefanhahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual changes look good to me.

However, the CI pipeline does not run through. Can adapt the javadoc of the class MamutViewStateXMLSerialization so that it does?

grafik

@tinevez tinevez merged commit 83f6947 into dev Oct 9, 2024
1 check failed
@tinevez tinevez deleted the rework-menus branch October 9, 2024 13:56
@tinevez
Copy link
Contributor Author

tinevez commented Oct 9, 2024

The actual changes look good to me.

However, the CI pipeline does not run through. Can adapt the javadoc of the class MamutViewStateXMLSerialization so that it does?

I take care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants