Better track coloring #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the track color was determine by the position of a track in the sorted track array, based on the root labels. In practice, for large number of tracks, this was not so great when editing tracks a lot. Indeed, the slightest track additon of link removal could completely change the order, hence the track coloring. Here we simply use the hash of the root label of a track to determine its color, making it independent of the other ones. The color of a track now only depends on the label of its root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the track color was determined by the position of a track in the sorted track array, based on the root labels.
In practice, for large number of tracks, this was not so great when editing tracks a lot. Indeed, the slightest track addition of link removal could completely change the order, hence the track coloring.
Here we simply use the hash of the root label of a track to determine its color, making it independent of the other ones. The color of a track now only depends on the label of its root.