Token color customizations settings from community material theme

[MathiasKandelborg]

Describe the bug
I naively installed Material Theme and uninstalled the community version on my Insiders edition.

All the customizations I spent a little while on fine-tuning, are completely whack.

Luckily, I could run the community version on the normal VS Code branch and sync my settings.

To Reproduce
Steps to reproduce the behavior:

1. Use settings as described below (change the theme name accordingly)
2. Use old deprecated theme extension - look at some code
3. Use new theme extension - look at some code
4. Behold the changes

Expected behavior
These settings:

    "[Community Material Theme Darker High Contrast]": {
      "comments": {
        "fontStyle": "italic",
        "foreground": "#696969"
      },
      "strings": {
        "fontStyle": "italic",
        "foreground": "#42af6e"
      },
      "keywords": {
        "foreground": "#69afad"
      },
      "variables": {
        "foreground": "#cacaca",
        "fontStyle": "italic"
      },
      "functions": "#63a2e7",
      "types": "#d16cc5",
      "textMateRules": [
        {
          "scope": "variable.other.constant",
          "settings": {
            "fontStyle": ""
          }
        },
        {
          "scope": "variable.other.object",
          "settings": {
            "fontStyle": ""
          }
        },
        {
          "scope": "variable.other.readwrite",
          "settings": {
            "fontStyle": ""
          }
        },
        {
          "scope": "support.type.property-name.json.comments",
          "settings": {
            "fontStyle": ""
          }
        }
      ]
    }
  },

Should work the same. Otherwise, there should be a migration guide for settings.

Screenshots

With new Material theme:

How it used to look:

[equinusocio]

Just remove the "Community " from "[Community Material Theme Darker High Contrast]".

Also make sure to disable semantic color highlight to replicate old syntax colorization, but we don't recommend it. If you want to keep vscode semantic highlight on (default) you may need to update the selectors. You can read more here #1274

[equinusocio]

We deprecated Community Material Theme in 2020, and the last visual update was in 2016. We offered many years to migrate actually. We just removed it from the marketplace now.

Make a migration guide for settings

There is, based on whether you use semantic highlight or not. Adapt your settings accordingly. But consider code scopes are changed a lot since 2016, so you may need to run scope inspector again to check the names (they also change based if semantic highlight feature is on or off)

Should work the same. Otherwise, there should be a migration guide for settings.

Go to vscode repository and report the issue to them, since semantic highlight is a vscode feature.

Make a migration guide for settings
OR explain that settings are different and show where to find out. This will still waste people's time but at least it's better than having to make an issue on GitHub to find out.

We don't want to replicate vscode documentation, you were just using an obsolete theme stuck in 2016 and never supported semantic highlight and new scopes released in 2020. What you think was a correct highlight was just missing highlight or global scope usage.

Your options

If you like to learn how Vscode has worked with semantic highlight since 2020, we encourage you to read their documentation about semantic highlight. Everyone should know the tools they're using.

• You can still use the legacy version which doesn't support semantic highlight
• You can just use the new theme with semantic highlight on, and enjoy the advanced code highlighting.
• You can use the "new" theme with semantic highlight off (check "With semantic highlight OFF" section), and customize what you don't like.

That's everything you should know and all the possibilities. There are no limitations.