Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing behavior of login with make_clients=True #63

Open
WardLT opened this issue Sep 17, 2021 · 0 comments
Open

Confusing behavior of login with make_clients=True #63

WardLT opened this issue Sep 17, 2021 · 0 comments

Comments

@WardLT
Copy link
Contributor

WardLT commented Sep 17, 2021

login will return a mix of Clients and Authorizers when you set make_clients=True. While this makes the code robust to users requesting authorizers for services that are not known by mdf_toolbox, it requires users to know what services are defined in their specific version of toolbox to know what output type(s) to expect . I suggest we throw errors instead.

Line in question:

if make_clients and scope in KNOWN_CLIENTS.keys():

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant