Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/_matrix/identity/api/v1/sign-ed25519 links in emails should use non-/_matrix namespace and have a better name #533

Open
richvdh opened this issue Nov 25, 2022 · 1 comment
Labels

Comments

@richvdh
Copy link
Member

richvdh commented Nov 25, 2022

Currently, email invites contain a link which includes a callback to https://matrix.org/_matrix/identity/api/v1/sign-ed25519 (or the vector.im equivalent). (See template).

This URI appears to be a bastardisation of the now-unspecced /v1/sign-ed25519 endpoint, in which the parameters which should be passed in the body are in fact passed as query-parameters.

Since this is a Sydent URI, generated by Sydent, there is no need for it to be in the spec; however what we should do is move it out of the /_matrix/ namespace (much like Synapse's /_synapse/client endpoints), and document it in Sydent's docs somewhere.

@richvdh
Copy link
Member Author

richvdh commented Nov 25, 2022

Also: its purpose is not just to sign some ed25519: it looks up a previously-stored invite. As such the name /sign-ed25519 is doubly crappy.

@richvdh richvdh changed the title /_matrix/identity/api/v1/sign-ed25519 links in emails should use non-/_matrix namespace /_matrix/identity/api/v1/sign-ed25519 links in emails should use non-/_matrix namespace and have a better name Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants